[MDEV-336] oqgraph 5.5 crashes in buildbot Created: 2012-06-13 Updated: 2012-08-25 Resolved: 2012-08-25 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | None |
| Affects Version/s: | 5.5.24, 5.3.8 |
| Fix Version/s: | 5.5.27, 5.3.8 |
| Type: | Bug | Priority: | Major |
| Reporter: | Sergei Golubchik | Assignee: | Sergei Golubchik |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Description |
|
Now we don't build OQGraph for 5.5 trees, because buildbot builders lack sufficiently new Boost ( When we tried to update Boost, OQGraph started failing.
|
| Comments |
| Comment by Arjen Lentz [ 2012-06-18 ] |
|
Sergei, thanks for creating this new dedicated issue. The bugreport still has logic issues in relation to the observed problem. At this point, my hypothesis is that rather than a newer version, that OQgraph codebase effectively requires a specific or older version of Boost to build. If you can please check what version of Boost was used for MariaDB 5.2, I believe it would have been 1.40 or 1.42 ? Note that earlier the OQGraph codebase included the Boost and Boost Graph libraries to make building easier, however this was removed on knielsen's request. One possible solution would be to put it back in? We can possibly tweak the codebase to take newer versions into account, but Boost appears to be a bit of a moving target so essentially we can expect it to keep breaking every time you start building in a newer OS version or the Boost libraries are updated in a distro. What do you reckon might be the best approach to fix the and minimise hassle in the future? |
| Comment by Sergei Golubchik [ 2012-06-18 ] |
|
Arjen, I didn't say that "oqgraph magically requires a different I know why it does, there is no magic here. We've changed the This bug report is about the fact that one some platforms OQgraph does I tried to repeat the failure, and it took me quite a while of We don't need to upgrade Boost regularly either, this change (1.42 to Anyway. In a few days we'll install Boost again on all builders, and Regards, |
| Comment by Arjen Lentz [ 2012-06-19 ] |
|
Serg, thanks for making sense in this issue, as Antony Curtis replied earlier on the MariaDB dev email thread - that should resolve the RTTI issue. — compare/5.5/storage/oqgraph/CMakeLists.txt 2012-06-11 22:12:28.000000000 -0700 IF(BOOST_OK)
|
| Comment by Sergei Golubchik [ 2012-06-20 ] |
|
Still crashes |
| Comment by Arjen Lentz [ 2012-07-16 ] |
|
Serg - trying to decode the status changes in JIRA for this issue. Regards, |
| Comment by Patryk Pomykalski [ 2012-07-26 ] |
|
I made some tests under ubuntu 10.04 32b with 2 boost versions: |
| Comment by Patryk Pomykalski [ 2012-07-27 ] |
|
Adding -fno-strict-aliasing for oqgraph seems to help on the newer boost versions (1.46+) |
| Comment by Sergei Golubchik [ 2012-07-28 ] |
|
Thanks, Patryk! I'll try to add this as a workaround, and let Arjen decide whether it'll be a final fix or not (in the new upstream of the OQGraph). |
| Comment by Arjen Lentz [ 2012-08-01 ] |
|
Serg - just for reference... there is no long a separate upstream of OQGraph maintained, OQGraph's primary copy lives in the MariaDB source tree. |
| Comment by Sergei Golubchik [ 2012-08-01 ] |
|
doesn't crash now. let's reopen the issue if it'll start crashing again |
| Comment by Patryk Pomykalski [ 2012-08-02 ] |
|
I still get the crash in tests with boost > 1.45 |
| Comment by Sergei Golubchik [ 2012-08-03 ] |
|
okay, I've reopened the issue. |
| Comment by Patryk Pomykalski [ 2012-08-04 ] |
|
Just tested at home on gentoo 64bit (boost 1.46.1, gcc 4.4.5) - same result: output from cmake: |
| Comment by Sergei Golubchik [ 2012-08-11 ] |
|
pushed -fno-strict-aliasing workaround. |
| Comment by Sergei Petrunia [ 2012-08-22 ] |
|
Still crashes in buildbot. Look for failures of oqgraph_basic in 5.3 |
| Comment by Sergei Golubchik [ 2012-08-25 ] |
|
pushed in 5.3 too |