[MDEV-3331] LP:992312 - Support spec file doesn't compile (5.5.23) Created: 2012-05-01 Updated: 2012-10-04 Resolved: 2012-10-04 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Shawn Sterling (Inactive) | Assignee: | Unassigned |
| Resolution: | Not a Bug | Votes: | 0 |
| Labels: | Launchpad | ||
| Attachments: |
|
| Description |
|
The ~/mariadb-5.5.23/debug/support-files/mysql.5.5.23.spec does not compile. This is the upstream (oracle) spec file, so I modified it to work with the mariadb source tarball. The only modification to it was: diff mysql.5.5.23.spec /build/SPECS/mariadb.5.5.23.spec doing a rpmbuild -ba mariadb.5.5.23.spec mostly builds (78% done) until the following error: Linking CXX executable mysqlbinlog Does anyone have a working spec file for 5.5.23? Thanks |
| Comments |
| Comment by Vladislav Vaintroub [ 2012-05-01 ] |
|
Re: Support spec file doesn't compile (5.5.23) |
| Comment by Shawn Sterling (Inactive) [ 2012-05-01 ] |
|
Re: Support spec file doesn't compile (5.5.23) g++ was already installed on this build system, but the following option in the upstream spec file prevents it's use: export CXX=${MYSQL_BUILD_CXX:-${CXX:-gcc}} After removing that line, it will compile properly; however, there is this related line as well: export CXXFLAGS=${MYSQL_BUILD_CXXFLAGS: The $RPM_OPT_FLAGS is basically unset unless someone has it setup for their build system (which I'll say is not common in my experience). So the question is, are the other options: -felide-constructors -fno-exceptions -fno-rtti appropriate for mariadb compiled with g++? The rest of the issues with the rpm look like missing files and and renames, of which I'll take care of and contribute the spec file back. Have a good day. |
| Comment by Vladislav Vaintroub [ 2012-05-02 ] |
|
Re: Support spec file doesn't compile (5.5.23) -felide-constructors is less familiar to me, but description of it does not sound inappropriate, i.e might be fine to compile with it |
| Comment by Shawn Sterling (Inactive) [ 2012-05-03 ] |
|
Re: Support spec file doesn't compile (5.5.23) I have tested compiling with both options and it compiles either way, so I am inclined to leave the CXXFLAGS alone. I have gone through and renamed the instances of MySQL-xxxx to mariadb-xxxx (capslock is for newbs) and I have added the additional files that mariadb needs and removed some files that mariadb no longer requires. I will put the spec file up in bzr shortly, I have put the spec file on github for the interim. https://github.com/shawn-sterling/mysql_stuff/tree/master/mariadb-5.5.23 |
| Comment by Vladislav Vaintroub [ 2012-07-17 ] |
|
Re: Support spec file doesn't compile (5.5.23) We would also recommend that 3rd parties build RPMs the same way as we do. Thus I'd close the bug as "Invalid" (in MariaDb, there is no need to maintain hand-written spec) . Still, many thanks for bringing the issue to our attention. |
| Comment by Rasmus Johansson (Inactive) [ 2012-07-17 ] |
|
Launchpad bug id: 992312 |