[MDEV-33220] clean up spider code patterns that could result in -wmaybe-uninitialized Created: 2024-01-10  Updated: 2024-01-19

Status: Open
Project: MariaDB Server
Component/s: Storage Engine - Spider
Fix Version/s: 10.4

Type: Task Priority: Major
Reporter: Yuchen Pei Assignee: Yuchen Pei
Resolution: Unresolved Votes: 0
Labels: None


 Description   

Reported by marko.

Instead of

  if (
 
    !(db_name = get_field(mem_root, table->field[0])) ||
 
    !(table_name = get_field(mem_root, table->field[1])) ||
 
    !(link_id = get_field(mem_root, table->field[2]))
 
  )
 
    DBUG_RETURN(HA_ERR_OUT_OF_MEM);

do

if (!(db_name = get_field(...))
 
  DBUG_RETURN(...);
 
if (!(table_name = get_field(...))
 
  DBUG_RETURN(...);
 
if (!(link_id = get_field(...))
 
  DBUG_RETURN(...);



 Comments   
Comment by Marko Mäkelä [ 2024-01-19 ]

The warnings are issued by GCC when building with -Og (optimize while trying to keep the executable debugger-friendly).

Generated at Thu Feb 08 10:37:17 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.