[MDEV-33090] plugin/auth_pam/testing/pam_mariadb_mtr.c doesn't compile on Solaris Created: 2023-12-20  Updated: 2024-01-08  Resolved: 2024-01-08

Status: Closed
Project: MariaDB Server
Component/s: Plugin - pam
Affects Version/s: 10.11.6
Fix Version/s: 10.4.33, 10.5.24, 10.6.17, 10.11.7, 11.0.5, 11.1.4, 11.2.3

Type: Bug Priority: Major
Reporter: Rainer Orth Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: None
Environment:

Solaris 11.4/x86 with GCC 13.2.0

Attachments: File ph.patch    

 Description   

`pam_mariadb_mtr.c` doesn't compile on Solaris:
```
In file included from /vol/src/mariadb/mariadb-10.11.6/plugin/auth_pam/testing/pam_mariadb_mtr.c:13:
/usr/include/security/pam_modules.h:14:9: error: unknown type name ‘pam_handle_t’
14 | pam_handle_t *__pamh,

```
`pam_handle_t` is declared in `<security/pam_appl.h>`, so reversing the include order fixes the bug.

 Comments   
Comment by Sergei Golubchik [ 2024-01-03 ]

Thanks, I've applied your patch and pushed into a stage branch. If it won't break anything on other platforms it'll be in the next release.

Generated at Thu Feb 08 10:36:19 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.