Hi holyfoot, ptal thanks:

e5366659081b570bade3bd190a679940c0275f5c

MDEV-32856 deprecate spider table params regarding table stats retrieval

MDEV-28007 deprecated spider_store_last_crd, spider_store_last_sts,

spider_load_crd_at_startup, spider_load_sts_at_startup, but it did not

do the same for the table params, so we have to do this before doing

MDEV-27995

ok to push.

Hi Roel, can you test the following, thanks

4fc825ce7a8 upstream/bb-11.4-mdev-32856-preview MDEV-32856 deprecate spider table params regarding table stats retrieval

BTW I just noticed that 11.4 is a moving target, so I suspect at some point you'll need to test the same changes but on a different commit

is this commit (4fc825ce7a8) a subset of f93c20081a8a ?

serg good catch! I think I did this before MDEV-28861 which
deprecates a lot more params. I've marked it as a part of that ticket,
but do you think we should close it as a duplicate instead? Their main
purposes are different but having both open could cause inconsistency
with the preview release I suppose?

I've noticed it when I cherry-picked f93c20081a8a first and then tried to cherry-pick 4fc825ce7a8 — git told me I can do an empty commit, skip, or abort. That is, as far as preview is concerned, all changes are already applied, whatever you do with these MDEVs won't matter for a preview.

If you want these MDEV's to be tested separately — keep them both, otherwise it'd make sense to close this MDEV and mark it as "is a part of" the other one.

Tested as part of MDEV-28861, in which commit (last file) the patch for this ticket was indeed already included.