[MDEV-32250] To benefit from MDEV-515 , please make option --no-autocommit default in mysqldump from 10.6 onwards Created: 2023-09-26  Updated: 2023-10-30

Status: Open
Project: MariaDB Server
Component/s: Scripts & Clients
Fix Version/s: 11.5

Type: Task Priority: Critical
Reporter: Rick Pizzi Assignee: Oleksandr Byelkin
Resolution: Unresolved Votes: 1
Labels: None

Issue Links:
Relates
relates to MDEV-515 innodb bulk insert Closed
relates to MDEV-24818 Concurrent use of InnoDB table is imp... Closed
relates to MDEV-5171 Add support for --innodb-optimize-ke... Closed

 Description   

In order to fully take advantage of bulk insert speed improvement brought by MDEV-515 , we need to have insert statements generated by mysqldump wrapped into a single transaction per table.

Mysqldump already has an option for that, called --no-autocommit.
My proposal is to make it TRUE by default from 10.6 (right now it is false).

Thanks,
Rick

 Comments   
Comment by Kristian Nielsen [ 2023-09-26 ]

Changing a default like that doesn't seem appropriate in a stable/GA release.
Any reason this particular change would be an exception?

Comment by Rick Pizzi [ 2023-09-26 ]

Because otherwise all the work that has been done in MDEV-515 will seldomly be used, if ever.

Comment by Kristian Nielsen [ 2023-09-26 ]

rpizzi That's not a valid reason for risking a change like this in a GA release.
The default can be changed in the next release and will be used by default there. Just like any other new feature.

Comment by Rick Pizzi [ 2023-09-26 ]

The fact that mysqldump produces dumps that are loaded in autocommit mode is a bug in itself.

Comment by Ralf Gebhardt [ 2023-10-11 ]

I have changed the fixVersion to 11.4 and the priority to critical (to get the change done).

We have discussed not to break the rules for GA releases here.

sanja_byelkin, please assign this to someone to get the change done.

Generated at Thu Feb 08 10:29:57 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.