[MDEV-32189] use icu for timezones on windows Created: 2023-09-16 Updated: 2024-01-31 Resolved: 2023-11-21 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Temporal Types |
| Fix Version/s: | 11.4.1 |
| Type: | Task | Priority: | Major |
| Reporter: | Sergei Golubchik | Assignee: | Vladislav Vaintroub |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||
| Description |
|
icu.lib is now apparently included by default in all supported versions on Windows. it can provide more portable results than Win32 API when dealing with time zones in Time_zone_system::get_timezone_information() and get_win_tzname(). |
| Comments |
| Comment by Rucha Deodhar [ 2023-11-21 ] |
|
Looks ok to push. Thanks ! |
| Comment by Daniel Black [ 2023-11-21 ] |
|
This needs a tester signoff first right - https://mariadb.com/kb/en/mariadb-quality-development-rules/ |
| Comment by Vladislav Vaintroub [ 2023-11-22 ] |
|
"New features" need tester signoff. Lets see it as a fix, that also adds unit tests for the previous functionality (also outside of Windows) |