[MDEV-3207] LP:612600 - Lost memory reported in valgrind in os_aio_simulated_handle Created: 2010-08-02  Updated: 2012-10-04  Resolved: 2012-10-04

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Michael Widenius Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: Launchpad

Attachments: XML File LPexportBug612600.xml     Text File LPexportBug612600_case612600.patch    

 Description   

When running the test innodb_plugin.innodb-use-sys-malloc (not support test), xtradb doesn't properly free memory when test is aborted.

How to repeat:

mysql-test-run --valgrind innodb_plugin.innodb-use-sys-malloc

Error output:

innodb_plugin.innodb_mysql w3 [ skipped ] Test requires: 'true'
***Warnings generated in error logs during shutdown after running tests: innodb_plugin.innodb-use-sys-malloc

==8801== 1,310,720 bytes in 3 blocks are still reachable in loss record 7 of 7
==8801== at 0x4C259AE: malloc (vg_replace_malloc.c:207)
==8801== by 0xA056A2: ut_malloc_low (ut0mem.c:106)
==8801== by 0x9B8896: os_aio_simulated_handle (os0file.c:4191)
==8801== by 0xA3F027: fil_aio_wait (fil0fil.c:4892)
==8801== by 0x9F07B7: io_handler_thread (srv0start.c:492)
==8801== by 0x504906F: start_thread (in /lib64/libpthread-2.9.so)
==8801== by 0x5FFE11C: clone (in /lib64/libc-2.9.so)

This affects MariaDB 5.1. MySQL 5.1 doesn't have this issue

 Comments   
Comment by Christoffer Hall (Inactive) [ 2010-08-04 ]

Re: Lost memory reported in valgrind in os_aio_simulated_handle
It seems the os_aio_thread_buffer for read/write combining gets allocated on the fly but never deallocated at the end. This simple patch fixes it.

Comment by Christoffer Hall (Inactive) [ 2010-08-04 ]

It seems the os_aio_thread_buffer for read/write combining gets allocated on the fly but never deallocated at the end. This simple patch fixes it.

Free buffers in os_aio_thread_buffer at cleanup
LPexportBug612600_case612600.patch

Comment by Christoffer Hall (Inactive) [ 2010-08-04 ]

Re: Lost memory reported in valgrind in os_aio_simulated_handle
Verified that it works on percona-xtradb

Comment by Rasmus Johansson (Inactive) [ 2010-08-04 ]

Launchpad bug id: 612600

Generated at Thu Feb 08 06:47:02 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.