[MDEV-32031] Some Rpl Tests use MTR variables for Save/Restore Instead of User Variables Created: 2023-08-28  Updated: 2024-01-25

Status: Open
Project: MariaDB Server
Component/s: Replication, Tests
Affects Version/s: 10.4, 10.5, 10.6, 10.10, 10.11, 11.0, 11.1, 11.2
Fix Version/s: 10.4, 10.5, 10.6, 10.11, 11.0

Type: Bug Priority: Minor
Reporter: Brandon Nesterenko Assignee: Brandon Nesterenko
Resolution: Unresolved Votes: 0
Labels: None


 Description   

Some replication tests use MTR variables (i.e. set with `let`) for saving and restoring global variables, but should use user variables instead, as if the value is different at the start of the test, the test will fail. For example, debug_dbug when running mtr with --debug-common.



 Comments   
Comment by Kristian Nielsen [ 2024-01-11 ]

I think the point is that the test will fail, because the .result file will contain the old value when the value is restored, like

    eval SET GLOBAL debug_dbug='$old_dbug';

right?

I agree that it's good to solve the problem by using user variables instead. Just want to point out that it's also fine to solve differently, eg. --disable-query-log for example, if that is more convenient in some specific cases.

Generated at Thu Feb 08 10:28:17 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.