[MDEV-31925] mysqld_upgrade --check-if-upgrade-is-needed leaks files Created: 2023-08-15  Updated: 2023-12-19  Resolved: 2023-12-19

Status: Closed
Project: MariaDB Server
Component/s: Upgrades
Affects Version/s: 10.2, 10.3, 10.4, 10.5, 10.6
Fix Version/s: 10.4.33, 10.5.24, 10.6.17, 10.11.7, 11.0.5, 11.1.4, 11.2.3

Type: Bug Priority: Minor
Reporter: Christian Roser Assignee: Daniel Black
Resolution: Fixed Votes: 0
Labels: Papercut, beginner-friendly


 Description   

Hi,

we discovered that mysql_upgrade with check-if-upgrade-is-needed leaks files under the tmp directory. It will like always create the mysql_upgrade-****** defaults-file but never clean it up.

should easily be fixable by something like that:

  if (opt_check_upgrade)
 
    free_used_memory();
 
    exit(upgrade_already_done(0) == 0);

see code

 Comments   
Comment by Gulshan Kumar Prasad [ 2023-11-25 ]

I'd like to work on this issue.

Comment by Sisi Huang [ 2023-12-18 ]

https://github.com/MariaDB/server/pull/2940

Comment by Daniel Black [ 2023-12-19 ]

Thank you hsser

Generated at Thu Feb 08 10:27:29 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.