[MDEV-31346] trx_purge_add_undo_to_history() is not optimal Created: 2023-05-25 Updated: 2023-06-07 Resolved: 2023-05-26 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB |
| Affects Version/s: | 10.4, 10.5, 10.6, 10.7, 10.8, 10.9, 10.10, 10.11, 11.0 |
| Fix Version/s: | 10.6.15, 10.9.8, 10.10.6, 10.11.5, 11.0.3, 11.1.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | Marko Mäkelä | Assignee: | Marko Mäkelä |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | performance | ||
| Description |
|
The function trx_purge_add_undo_to_history(), which is called after each transaction commit or rollback that had modified persistent tables, is not optimal. It calls trx_undo_set_state_at_finish() in a different compilation unit and evaluates a condition on undo->state several times. We could get a small performance improvement by simplifying this. |