[MDEV-31087] Merge new release of InnoDB 5.7.42 to 10.3 Created: 2023-04-19  Updated: 2023-07-24  Resolved: 2023-04-19

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: N/A
Fix Version/s: N/A

Type: Bug Priority: Blocker
Reporter: Marko Mäkelä Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
blocks MDEV-31620 Q3 2023 release merge Closed
blocks MDEV-31765 Merge new release of InnoDB 5.7.43 to... Closed
is blocked by MDEV-13795 ALTER TABLE…DROP PRIMARY KEY, ADD PRI... Closed
is blocked by MDEV-14332 Corruption during online table-rebuil... Closed
is blocked by MDEV-30422 Merge new release of InnoDB 5.7.41 to... Closed

 Description   

From https://github.com/mysql/mysql-server
 + 551338af241...8d1dd573901 5.7                  -> origin/5.7  (forced update)
 + 1bfe02bdad6...e57893fef5b 8.0                  -> origin/8.0  (forced update)
 + 84ef2cea3ee...4325596603f cluster-7.4          -> origin/cluster-7.4  (forced update)
 + 97e108f10e5...2400ba6fbef cluster-7.5          -> origin/cluster-7.5  (forced update)
 + 4956fa44719...9c357485159 cluster-7.6          -> origin/cluster-7.6  (forced update)
 * [new tag]                 mysql-5.7.42         -> mysql-5.7.42
 * [new tag]                 mysql-8.0.33         -> mysql-8.0.33
 * [new tag]                 mysql-cluster-7.5.30 -> mysql-cluster-7.5.30
 * [new tag]                 mysql-cluster-7.6.26 -> mysql-cluster-7.6.26
 * [new tag]                 mysql-cluster-8.0.33 -> mysql-cluster-8.0.33

Because there was a force-push to the branches, I had to figure out a creative way of finding the changes:

git diff -I'Copyright \(c\).*Oracle' mysql-5.7.41..mysql-5.7.42 storage/innobase/

This returns only 31 lines, all corresponding to the following change:

Not applicable to MariaDB Server

Bug#34750489: applying a updated online log may access out-of-bounds memory
If I change the send OPTIMIZE TABLE t1 in the test case to the following, it will fail because MariaDB will refuse the operation:

SET debug_sync = 'alter_table_update_log signal send_concurrent WAIT_FOR concurrent_done';
ALTER TABLE t1 FORCE, LOCK=NONE, ALGORITHM=INPLACE;

mysqltest: At line 31: query 'ALTER TABLE t1 FORCE, LOCK=NONE, ALGORITHM=INPLACE' failed: ER_ALTER_OPERATION_NOT_SUPPORTED (1845): ALGORITHM=INPLACE is not supported for this operation. Try ALGORITHM=COPY

In MariaDB 10.2.11 (which was released in November 2017) we addressed MDEV-13795 and MDEV-14332 by refusing online ALTER TABLE rebuild when indexed virtual columns would have to be evaluated while applying the log.



 Comments   
Comment by Marko Mäkelä [ 2023-05-15 ]

For the record, there seems to have been another force-push. I just updated another old checkout:

remote: Enumerating objects: 27095, done.
remote: Counting objects: 100% (20606/20606), done.
remote: Total 27095 (delta 20606), reused 20606 (delta 20606), pack-reused 6489
Receiving objects: 100% (27095/27095), 16.71 MiB | 8.63 MiB/s, done.
Resolving deltas: 100% (23598/23598), completed with 14223 local objects.
From https://github.com/mysql/mysql-server
   551338af241..f091fb09ee1  5.7                  -> origin/5.7
   1bfe02bdad6..ea7087d8850  8.0                  -> origin/8.0
   97e108f10e5..4b1025b4920  cluster-7.5          -> origin/cluster-7.5
   4956fa44719..fd71b7c3eb6  cluster-7.6          -> origin/cluster-7.6
 * [new branch]              dependabot/pip/extra/libcbor/doc/source/flask-2.3.2 -> origin/dependabot/pip/extra/libcbor/doc/source/flask-2.3.2
 * [new tag]                 mysql-5.7.40-testing -> mysql-5.7.40-testing
 * [new tag]                 mysql-5.7.42         -> mysql-5.7.42
 * [new tag]                 mysql-8.0.33         -> mysql-8.0.33
 * [new tag]                 mysql-cluster-7.5.30 -> mysql-cluster-7.5.30
 * [new tag]                 mysql-cluster-7.6.26 -> mysql-cluster-7.6.26
 * [new tag]                 mysql-cluster-8.0.33 -> mysql-cluster-8.0.33

The commit hash for the not-applicable bug fix was changed to
Bug#34750489: applying a updated online log may access out-of-bounds memory

Generated at Thu Feb 08 10:21:11 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.