[MDEV-30968] mariadb-backup does not copy Aria logs if aria_log_dir_path is used Created: 2023-03-30  Updated: 2023-07-03  Resolved: 2023-04-21

Status: Closed
Project: MariaDB Server
Component/s: mariabackup
Affects Version/s: 10.4, 10.5, 10.6, 10.7, 10.8, 10.9, 10.10, 10.11
Fix Version/s: 11.1.1, 10.11.3, 11.0.2, 10.4.29, 10.5.20, 10.6.13, 10.8.8, 10.9.6, 10.10.4

Type: Bug Priority: Critical
Reporter: Alexander Barkov Assignee: Alexander Barkov
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
is blocked by MDEV-30971 Add a new system variable aria_data_h... Closed
is blocked by MDEV-31039 mariadb-backup: remove global variabl... Closed
Problem/Incident
causes MDEV-31251 MDEV-30968 breaks running mariabackup... Open

 Description   

If I add `aria-log-dir-path` to my.cnf, e.g.:

[mariadb-10.5]
 
aria-log-dir-path=/opt/mariadb-10.5/data-aria-logs

start the server, then run maridb-backup --backup,
Aria logs do not get copied to the backup directory:

$ ls -l /opt/mariadb-10.5/backup/xtrabackup_backupfiles/
 
total 77856
 
-rw-rw----. 1 bar bar      285 Mar 30 09:39 backup-my.cnf
 
-rw-rw----. 1 bar bar 79691776 Mar 30 09:39 ibdata1
 
-rw-rw----. 1 bar bar     2560 Mar 30 09:39 ib_logfile0
 
drwx------. 2 bar bar     4096 Mar 30 09:39 mysql
 
drwx------. 2 bar bar     4096 Mar 30 09:39 performance_schema
 
drwx------. 2 bar bar     4096 Mar 30 09:39 test
 
-rw-rw----. 1 bar bar       79 Mar 30 09:39 xtrabackup_checkpoints
 
-rw-rw----. 1 bar bar      417 Mar 30 09:39 xtrabackup_info

Notice, there are no Aria log files ^^^.

These log files from a non-default directory did not get copied:

$ ls -l /opt/mariadb-10.5/data-aria-logs
 
total 12
 
-rw-rw----. 1 bar bar 8192 Mar 30 09:39 aria_log.00000001
 
-rw-rw----. 1 bar bar   52 Mar 30 09:39 aria_log_control



 Comments   
Comment by Alexander Barkov [ 2023-04-14 ]

Hello vlad.lesin,

Can you please review a patch:
https://github.com/MariaDB/server/commit/cb0588b70065e8e63379b2b9d33cd67d03bddd98
?

Thanks.

Comment by Alexander Barkov [ 2023-04-17 ]

Hello vlad.lesin,

please review a new patch version:

https://github.com/MariaDB/server/commit/fd3222bce583b55a512a24c1cd655798ad21d17a

Thanks

Comment by Vladislav Lesin [ 2023-04-18 ]

https://github.com/MariaDB/server/commit/fd3222bce583b55a512a24c1cd655798ad21d17a looks good to me

Generated at Thu Feb 08 10:20:15 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.