[MDEV-30921] storage/perfschema/table_helper.h: sprintf -> snprintf Created: 2023-03-24 Updated: 2023-05-31 Resolved: 2023-05-22 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | None |
| Affects Version/s: | 10.4 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Arunesh Choudhary | Assignee: | Unassigned |
| Resolution: | Incomplete | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Failing to compile with AppleClang 14.0.0.14000029. |
| Comments |
| Comment by Sergei Golubchik [ 2023-04-19 ] |
|
what's the error message? |
| Comment by Daniel Lenski [ 2023-04-20 ] |
|
I have no idea what's being specifically requested here, but Chaloff from AWS has been doing a bunch of work to replace sprintf → snprintf. See these open PRs in particular: |
| Comment by Arunesh Choudhary [ 2023-04-21 ] |
|
Build was failing on macOS due to sprintf |
| Comment by Daniel Lenski [ 2023-04-21 ] |
What does that mean, "build was failing"? Does it mean that the version of `clang` being used emits a warning for every usage of `sprintf` rather than `snprintf`? Is/was this related to the now-closed https://github.com/MariaDB/server/pull/2573? |
| Comment by Mikhail Chalov [ 2023-05-31 ] |
|
Submitted fix for this issue https://github.com/MariaDB/server/pull/2653 Would be nice if somebody can review it |