[MDEV-30647] Remove Current_Pos from MASTER_USE_GTID options Created: 2023-02-13 Updated: 2023-12-21 Resolved: 2023-12-08 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Replication |
| Fix Version/s: | N/A |
| Type: | Task | Priority: | Major |
| Reporter: | Brandon Nesterenko | Assignee: | Brandon Nesterenko |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||
| Description |
|
Where Additional behaviors to consider in this removal:
|
| Comments |
| Comment by Kristian Nielsen [ 2023-09-18 ] |
|
We need to keep the syntax CHANGE MASTER TO MASTER_USE_GTID=current_pos for backwards compatibility. So it must not be removed. There's also no technical need to remove MASTER_USE_GTID=current_pos. It uses the @@gtid_current_pos which is also needed for the MASTER_DEMOTE_TO_SLAVE. And it works as intended and documented. So the MASTER_USE_GTID should stay, it's just good to have the MASTER_DEMOTE_TO_SLAVE as an alternative that works better for "sloppy" setups where manual updates are occasionally done on the slave. |
| Comment by Andrei Elkin [ 2023-09-18 ] |
|
I don't have any strong opinion on this. When knielsen points to the "old" method as still useful, we should not rush to remove it. |
| Comment by Brandon Nesterenko [ 2023-09-19 ] |
|
If we aren't going to remove the Current_Pos option, should its deprecation warning be removed? Or perhaps changed to a note that MASTER_DEMOTE_TO_SLAVE should be considered instead. |
| Comment by Kristian Nielsen [ 2023-09-19 ] |
|
bnestere That sounds good to me. |
| Comment by Brandon Nesterenko [ 2023-12-08 ] |
|
The option is being kept for backwards compatibility, as well as many users still use it. |