[MDEV-30464] Add a spider testsuite for known bugs Created: 2023-01-25  Updated: 2023-04-14  Resolved: 2023-04-14

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Spider
Fix Version/s: N/A

Type: Task Priority: Major
Reporter: Yuchen Pei Assignee: Yuchen Pei
Resolution: Won't Fix Votes: 1
Labels: None


 Description   

Considering there are many related bugs in spider, and there seem to be more bugs than we can work on simultaneously, I have the following idea.

  • Create a testcase (e.g. under a testsuite "spider/unfixed") expecting failure as described in the bug, so that the test passes on expected failure. Push the testcase.
  • Work on the issue or any other issue
  • If while working on another issue, the testcase fails, check what the failure means
    • if the failure indicates the bug may have been fixed (e.g. instead of expected failure, the test exhibits expected behaviour), check whether it is indeed fixed
    • in any case, update the jira issue and the testcase based on the new info if needed

Failure in the suite should not be blocking a push, in any case.

Tickets we can add unfixed tests:

 Comments   
Comment by Yuchen Pei [ 2023-01-25 ]

holyfoot PTAL https://github.com/MariaDB/server/commit/a22791ab96d

The testsuite does not pass because it is empty, but you can run mtr --suite spider/unfixed on the following commit containing a test for mdev-29676:

https://github.com/MariaDB/server/commit/4a5f5f0d38e

Comment by Yuchen Pei [ 2023-04-14 ]

I think using disabled.def is a cleaner approach, see e.g. storage/spider/mysql-test/spider/bugfix/disabled.def. Closing this ticket as Won't Fix.

Generated at Thu Feb 08 10:16:26 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.