[MDEV-3035] LP:507279 - Compile error on Visual C++ set_var.cc Created: 2010-01-14  Updated: 2012-10-04  Resolved: 2012-10-04

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Alex Budovski (Inactive) Assignee: Michael Widenius
Resolution: Fixed Votes: 0
Labels: Launchpad

Attachments: XML File LPexportBug507279.xml    

 Description   

5>.\set_var.cc(1204) : error C2065: 'maria_delay_key_write' : undeclared identifier

The code in question references a variable that is not in scope. <maria.h> must be included, perhaps conditionally.

A similar variable, myisam_delay_key_write is in scope, because <myisam.h> is included.

Including the maria.h fixes the problem.

 Comments   
Comment by Alex Budovski (Inactive) [ 2010-01-14 ]

Re: Compile error on Visual C++ set_var.cc
Suggested fix:

=== modified file 'sql/set_var.cc'
— sql/set_var.cc 2009-12-03 11:19:05 +0000
+++ sql/set_var.cc 2010-01-14 01:25:28 +0000
@@ -58,6 +58,11 @@
#include <my_getopt.h>
#include <thr_alarm.h>
#include <myisam.h>
+
+#ifdef WITH_MARIA_STORAGE_ENGINE
+#include <maria.h>
+#endif
+
#include <my_dir.h>
#include <waiting_threads.h>
#include "events.h"

Comment by Michael Widenius [ 2010-01-14 ]

[Bug 507279] Re: Compile error on Visual C++ set_var.cc

Hi!

>>>>> "Alex" == Alex Budovski <abudovski@gmail.com> writes:

Alex> Suggested fix:
Alex> === modified file 'sql/set_var.cc'
Alex> — sql/set_var.cc 2009-12-03 11:19:05 +0000
Alex> +++ sql/set_var.cc 2010-01-14 01:25:28 +0000
Alex> @@ -58,6 +58,11 @@
Alex> #include <my_getopt.h>
Alex> #include <thr_alarm.h>
Alex> #include <myisam.h>
Alex> +
Alex> +#ifdef WITH_MARIA_STORAGE_ENGINE
Alex> +#include <maria.h>
Alex> +#endif
Alex> +
Alex> #include <my_dir.h>
Alex> #include <waiting_threads.h>
Alex> #include "events.h"

Thanks, will do this.

In the future we will move this variable to ha_maria.cc, but for now
this is ok.

Regards,
Monty

Comment by Rasmus Johansson (Inactive) [ 2010-02-11 ]

Launchpad bug id: 507279

Generated at Thu Feb 08 06:45:52 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.