[MDEV-30332] PLUGIN_VAR_DEPRECATED fails to throw a warning on startup Created: 2023-01-03  Updated: 2023-02-27  Resolved: 2023-01-04

Status: Closed
Project: MariaDB Server
Component/s: Server
Affects Version/s: 10.9.0, 10.3.35, 10.4.25, 10.5.16, 10.6.8, 10.7.4, 10.8.3, 10.10.0, 11.0.0
Fix Version/s: N/A

Type: Bug Priority: Critical
Reporter: Marko Mäkelä Assignee: Yuchen Pei
Resolution: Duplicate Votes: 0
Labels: deprecated_feature

Issue Links:
PartOf
is part of MDEV-28671 Presentation of aliases in `mariadbd ... Stalled
Problem/Incident
is caused by MDEV-27730 Add PLUGIN_VAR_DEPRECATED flag to plu... Closed
Relates
relates to MDEV-27735 Deprecate the parameter innodb_change... Closed
relates to MDEV-29983 Deprecate innodb_file_per_table Closed
relates to MDEV-30731 Deprecated variables are not consiste... Open

 Description   

The flag PLUGIN_VAR_DEPRECATED that was implemented in MDEV-27730 works only partially. No deprecation warnings are being shown on server startup! Here is a simple test case:

./mtr --mysqld=--plugin-load-add=ha_example --mysqld=--example-deprecated-var=1 mtr-example.self
grep -i deprecated var/log/mysqld.1.err

10.3 e51a1d6fc0c105d56c6f05efb3d9fd05b7e4f22f

$ /dev/shm/10.3/sql/mysqld --defaults-group-suffix=.1 --defaults-file=/dev/shm/10.3/mysql-test/var/my.cnf --log-output=file --plugin-load-add=ha_example --example-deprecated-var=1 --core-file --loose-debug-sync-timeout=300

Note that there is no warning for specifying a deprecated parameter on startup. This kind of defeats the purpose of giving an early warning about parameters that are going to be removed, such as MDEV-27735 or MDEV-29983.

Before 10.7, the flag was only used by the "example" plugin. In 10.7, it was used in the Spider storage engine, and in 10.9 for InnoDB.


Generated at Thu Feb 08 10:15:27 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.