[MDEV-3031] LP:550974 - Windows compile error in ma_loghandler.c Created: 2010-03-29  Updated: 2013-07-25  Resolved: 2013-07-25

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Georg Richter Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: Launchpad

Attachments: XML File LPexportBug550974.xml    

 Description   

compilation of ma_loghandler.c fails in line 1398, since fd was declared after macro call LINT_INIT_STRUCT()

Suggested fix:
=== modified file 'storage/maria/ma_loghandler.c'
— storage/maria/ma_loghandler.c 2010-03-10 10:32:14 +0000
+++ storage/maria/ma_loghandler.c 2010-03-29 14:45:27 +0000
@@ -1394,8 +1394,9 @@

{
LOGHANDLER_FILE_INFO info;
+ File fd;
LINT_INIT_STRUCT(info);

  • File fd= open_logfile_by_number_no_cache(file);
    + fd= open_logfile_by_number_no_cache(file);
    if ((fd < 0) ||
    (translog_read_file_header(&info, fd) | my_close(fd, MYF(MY_WME))))
    {

 Comments   
Comment by Oleksandr Byelkin [ 2010-03-30 ]

Re: [Bug 550974] [NEW] Windows compile error in ma_loghandler.c
Hi!

29 марта 2010, в 18:51, Georg Richter написал(а):

> Public bug reported:
>
> compilation of ma_loghandler.c fails in line 1398, since fd was
> declared after macro call LINT_INIT_STRUCT()
>
> Suggested fix:
> === modified file 'storage/maria/ma_loghandler.c'
> — storage/maria/ma_loghandler.c 2010-03-10 10:32:14 +0000
> +++ storage/maria/ma_loghandler.c 2010-03-29 14:45:27 +0000
> @@ -1394,8 +1394,9 @@
>
> {
> LOGHANDLER_FILE_INFO info;
> + File fd;
> LINT_INIT_STRUCT(info);
> - File fd= open_logfile_by_number_no_cache(file);
> + fd= open_logfile_by_number_no_cache(file);
> if ((fd < 0) ||
> (translog_read_file_header(&info, fd) | my_close(fd,
> MYF(MY_WME))))
> {
>

Thank you a lot, but I'd better move LINT_INIT_STRUCT(info); lower...

Comment by Bo Thorsen (Inactive) [ 2010-04-09 ]

Re: Windows compile error in ma_loghandler.c
Sanja and I have fixed the two places where this was seen. And I fixed another windows compilation issue. lp:maria compiles for me on Windows Vista using Visual Studio 2008 now.

Comment by Rasmus Johansson (Inactive) [ 2010-06-28 ]

Launchpad bug id: 550974

Generated at Thu Feb 08 06:45:51 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.