[MDEV-30205] change /usr/share/mysql to /usr/share/mariadb Created: 2022-12-12  Updated: 2023-04-11  Resolved: 2023-04-11

Status: Closed
Project: MariaDB Server
Component/s: Packaging
Fix Version/s: 11.1.1

Type: Task Priority: Major
Reporter: Daniel Black Assignee: Daniel Black
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
PartOf
is part of MDEV-30201 Remove MySQL names Open

 Description   

To facilitate the removal of mysql naming in MariaDB products changing this directory name is part of it.

These appear to be largely internally used covering

  • mysql-test (rename to mariadb-test at same time?)
  • minibenchmark
  • translations of error messages
  • install/ upgrade scripts used by mariadb-install-db
  • example files
  • galera/mroonga/apparmor/selinux/systemd files
  • /usr/share/mysql/mysql.init

 Comments   
Comment by Daniel Black [ 2022-12-12 ]

CI tests in progress:

https://salsa.debian.org/grooverdan/mariadb-server/-/pipelines/469269

https://github.com/MariaDB/server/pull/2370

Comment by Daniel Black [ 2022-12-13 ]

pr: https://github.com/MariaDB/server/pull/2370

Will need corp bb changes that use /usr/share/mysql/mysql-test and mysql-test-run.pl directly.

Same debian CI warnings https://salsa.debian.org/illuusio/mariadb-server/-/pipelines/469916 as the 10.11 baseline https://salsa.debian.org/illuusio/mariadb-server/-/pipelines/469916

On 10.4 upgrade packging fix related to '/usr/share/mariadb/mysql.init': No such file or directory but otherwise ok.

Comment by Daniel Black [ 2022-12-21 ]

replaced with PR https://github.com/MariaDB/server/pull/2392

Comment by Sergei Golubchik [ 2023-03-07 ]

danblack, internal files don't matter, of course, do whatever you like. But installed scripts and particularly directories — should there be compatibility symlinks too?

Comment by Daniel Black [ 2023-04-05 ]

The closest ones I though could potentially use a symlink, I don't think its worth the effort:

  • mini-benchmark
  • usr/share/mariadb/ {locale}

    I consider internal

  • usr/share/mariadb/maria_add_gis_sp_bootstrap.sql
  • usr/share/mariadb/mariadb_performance_tables.sql
  • usr/share/mariadb/mariadb_sys_schema.sql
  • usr/share/mariadb/mariadb_system_tables.sql
  • usr/share/mariadb/mariadb_system_tables_data.sql
  • usr/share/mariadb/mariadb_test_data_timezone.sql
  • usr/share/mariadb/mariadb_test_db.sql
  • usr/share/mariadb/mariadb-test/m* (scripts)

If you agree on no-compatibility links, I'll rebase, and get a PR ready for BB (corp) on https://github.com/MariaDB/mariadb.org-tools/tree/master/buildbot to handle the MTR location change.

Comment by Daniel Black [ 2023-04-06 ]

Rebase PR. No significant changes. Still couldn't think of anything worth a symlink compat package.

Corp BB pr so it doesn't fall over upon merge created - https://github.com/MariaDB/mariadb.org-tools/pull/169 and will be a prerequisite for merge.

Generated at Thu Feb 08 10:14:29 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.