[MDEV-29630] Remove unneded code in join_read_always_key() Created: 2022-09-25 Updated: 2023-12-22 |
|
| Status: | Stalled |
| Project: | MariaDB Server |
| Component/s: | Optimizer |
| Fix Version/s: | 11.5 |
| Type: | Task | Priority: | Minor |
| Reporter: | Sergei Petrunia | Assignee: | Oleg Smirnov |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Description |
|
join_read_always_key() has this code:
The if (!table->file->inited) {...} part is (or should be) redundant. This task is to remove it. Wait for the testsuite to pass . |
| Comments |
| Comment by Weijun Huang [ 2023-03-22 ] |
|
Could I pick it ticket up? It seems it still need to work. |
| Comment by Oleg Smirnov [ 2023-03-22 ] |
|
Sure, Weijun Huang, please do. |
| Comment by Oleg Smirnov [ 2023-03-27 ] |
|
Turns out the code is actually is use, we cannot remove it. Removing the code breaks almost everything: https://buildbot.mariadb.org/#/grid?branch=refs/pull/2563/merge. |
| Comment by Oleg Smirnov [ 2023-03-29 ] |
|
We decided to look more thoroughly to the cases when this code is executed. These could be particular types of queries or tables like for example, semi-joins, derived tables and so on. |