[MDEV-29607] binlog.binlog_checkpoint fails in buildbot with result content mismatch Created: 2022-09-22  Updated: 2024-01-23  Resolved: 2022-11-25

Status: Closed
Project: MariaDB Server
Component/s: Replication
Affects Version/s: 10.5, 10.6, 10.7, 10.8, 10.9, 10.10, 10.11
Fix Version/s: 10.5.19, 10.6.12, 10.7.8, 10.8.7, 10.9.5, 10.10.3

Type: Bug Priority: Major
Reporter: Brandon Nesterenko Assignee: Brandon Nesterenko
Resolution: Fixed Votes: 0
Labels: None


 Description   

Since MDEV-24660, binlog.binlog_checkpoint occasionally fails in buildbot with a result content mismatch.

 
binlog.binlog_checkpoint 'innodb,row'    w3 [ fail ]
        Test ended at 2022-09-21 18:53:23
 
CURRENT_TEST: binlog.binlog_checkpoint
--- /mnt/buildbot/build/mariadb-10.11.0/mysql-test/suite/binlog/r/binlog_checkpoint.result	2022-09-21 04:44:32.000000000 -0400
+++ /mnt/buildbot/build/mariadb-10.11.0/mysql-test/suite/binlog/r/binlog_checkpoint.reject	2022-09-21 18:53:23.284532290 -0400
@@ -169,9 +169,9 @@
 master-bin.000002	#	Format_desc	#	#	SERVER_VERSION, BINLOG_VERSION
 master-bin.000002	#	Gtid_list	#	#	[]
 master-bin.000002	#	Binlog_checkpoint	#	#	master-bin.000001
-master-bin.000002	#	Binlog_checkpoint	#	#	master-bin.000002
 master-bin.000002	#	Gtid	#	#	GTID #-#-#
 master-bin.000002	#	Query	#	#	use `test`; CREATE TABLE tm (a INT) ENGINE = myisam
+master-bin.000002	#	Binlog_checkpoint	#	#	master-bin.000002
 master-bin.000002	#	Gtid	#	#	BEGIN GTID #-#-#
 master-bin.000002	#	Query	#	#	use `mtr`; INSERT INTO test_suppressions (pattern) VALUES ( NAME_CONST('pattern',_latin1'Table \'./test/tm\' is marked as crashed' COLLATE 'latin1_swedish_ci'))
 master-bin.000002	#	Query	#	#	COMMIT
 
mysqltest: Result content mismatch
 
 - saving '/mnt/buildbot/build/mariadb-10.11.0/mysql-test/var/3/log/binlog.binlog_checkpoint-innodb,row/' to '/mnt/buildbot/build/mariadb-10.11.0/mysql-test/var/log/binlog.binlog_checkpoint-innodb,row/'
 
Retrying test binlog.binlog_checkpoint, attempt(2/3)...
 
worker[3] > Restart  - not started



 Comments   
Comment by Brandon Nesterenko [ 2022-09-27 ]

Hi Andrei!

This is ready for review. I tried to fix the test case to be explicit about what is being validated so the race condition becomes irrelevant.

The commit: df9fb49

Comment by Andrei Elkin [ 2022-11-24 ]

Thanks for a tidy cleanup !

Comment by Brandon Nesterenko [ 2022-11-25 ]

Pushed into 10.5 as 812443c

Generated at Thu Feb 08 10:09:55 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.