[MDEV-29275] typos (debian, Docs, include) Created: 2022-08-08  Updated: 2022-12-20  Resolved: 2022-12-20

Status: Closed
Project: MariaDB Server
Component/s: Documentation
Fix Version/s: 10.3.38, 10.4.28, 10.5.19, 10.6.12, 10.7.8, 10.8.7, 10.9.5, 10.10.3

Type: Task Priority: Minor
Reporter: Eric Lindblad (Inactive) Assignee: Ian Gilfillan
Resolution: Fixed Votes: 0
Labels: None


 Description   

debian

any of these files maintained outside the repo

some of the content in mariadb-server.postinst may be 15+ years old

since opening the ticket the path on the first sed command was corrected

sed -i "s/Fragmnt/Fragment/g" server/debian/additions/mariadb-report
sed -i "s/avoitda 800+ lines/avoid an 800+ line/g" server/debian/salsa-ci.yml
sed -i "s/elsewere/elsewhere/g" server/debian/additions/mariadb-report
sed -i "s/embeded/embedded/g" server/debian/not-installed
sed -i "s/formated/formatted/g" server/debian/source/lintian-overrides
sed -i "s/respose/response/g" server/debian/additions/innotop/innotop
sed -i "s/somewhen/somehow/g" server/debian/mariadb-server.postinst

Docs

sed -i "s/asymmetrict/asymmetric/g" server/Docs/README-wsrep
sed -i "s/avalably/avalable/g" server/Docs/myisam.txt
sed -i "s/seqeuncing/sequencing/g" server/Docs/README-wsrep
sed -i "s/statemnents/statements/g" server/Docs/README-wsrep

include

could be rewritten (awkward comment)

$ perl -ne 'print if $. eq 531 .. 536' server/include/mysql/plugin.h
/*
  MariaDB extension for plugins declaration structure.
 
  It also copy current MySQL plugin fields to have more independency
  in plugins extension
*/
$ 

should any headers not be edited owing to copyrights

since opening the ticket the spelling as 'general' was corrected

sed -i "s/Assight/Assign/g" server/include/waiting_threads.h
sed -i "s/Converst/Convert/g" server/include/json_lib.h
sed -i "s/Dupplicate/Duplicate/g" server/include/my_base.h
sed -i "s/Uppdate/Update/g" server/include/my_base.h
sed -i "s/accordinging/accordingly/g" server/include/my_sys.h
sed -i "s/avalably/available/g" server/include/my_base.h
sed -i "s/calcaluted/calculated/g" server/include/my_base.h
sed -i "s/containining/containing/g" server/include/mysql.h
sed -i "s/contens/contents/g" server/include/my_dir.h
sed -i "s/convertable/convertible/g" server/include/m_ctype.h
sed -i "s/corrresponds/corresponds/g" server/include/mysql/plugin_ftparser.h
sed -i "s/dupplicated/duplicated/g" server/include/myisammrg.h
sed -i "s/easyier/easier/g" server/include/my_global.h
sed -i "s/ecnrypt/encrypt/g" server/include/my_sys.h
sed -i "s/everithing/everything/g" server/include/mysql/service_my_snprintf.h
sed -i "s/extendible/extendable/g" server/include/lf.h
sed -i "s/funktions/functions/g" server/include/myisammrg.h
sed -i "s/funktions/functions/g" server/include/heap.h
sed -i "s/funktions/functions/g" server/include/myisam.h
sed -i "s/generell/general/g" server/include/queues.h
sed -i "s/guarenteed/guaranteed/g" server/include/my_rdtsc.h
sed -i "s/hanlder/handler/g" server/include/my_base.h
sed -i "s/indentity/identity/g" server/include/mysql/psi/mysql_thread.h
sed -i "s/inplementation/implementation/g" server/include/m_ctype.h
sed -i "s/mest/must/g" server/include/mysql/service_sql.h
sed -i "s/multuple/multiple/g" server/include/mysql/service_base64.h
sed -i "s/nesessary/necessary/g" server/include/my_sys.h
sed -i "s/precession/precision/g" server/include/my_decimal_limits.h
sed -i "s/provdes/provides/g" server/include/mysql/service_thd_timezone.h
sed -i "s/referense/reference/g" server/include/heap.h
sed -i "s/referense/reference/g" server/include/myisam.h
sed -i "s/rerurn/return/g" server/include/m_ctype.h
sed -i "s/resourses/resources/g" server/include/ma_dyncol.h
sed -i "s/statisfied/satisfied/g" server/include/my_compare.h
sed -i "s/statment/statement/g" server/include/mysql/psi/psi.h
sed -i "s/stemms/stems/g" server/include/my_global.h
sed -i "s/tertiarty/tertiary/g" server/include/m_ctype.h



 Comments   
Comment by Eric Lindblad (Inactive) [ 2022-08-08 ]

incidentally the spelling forceintervall/intervall/intervalls (.c, .h and .result files) and uppdated/uppdates (.c and .test files) is likely due to incorrect translation from Swedish, and, would corrections forceinterval/interval/intervals be authorised

updated/updates solely appears in comments

$ grep -n intervall server/sql/share/errmsg-utf8.txt
6724:        swe "Reorganisering av rangepartitioner kan inte ändra den totala intervallet utom för den sista partitionen där intervallet kan utökas"
$ grep -n uppdate server/sql/share/errmsg-utf8.txt
2453:        swe "Tabell '%-.192s' kan inte uppdateras emedan den är låst för läsning"
3198:        swe "För att ändra lösenord för andra måste du ha rättigheter att uppdatera mysql-databasen"
4101:        swe "Du använder 'säker uppdateringsmod' och försökte uppdatera en tabell utan en WHERE-sats som använder sig av en nyckel"
5425:        swe "Tabell %-.100s använd med '%s' är inte uppdateringsbar"
7967:        swe "FOREIGN KEY constraint för tabell '%.192s', posten '%-.192s' kan inte uppdatera barntabell '%.192s' på grund av nyckel '%.192s'"
7974:        swe "FOREIGN KEY constraint för tabell '%.192s', posten '%-.192s' kan inte uppdatera en barntabell på grund av UNIQUE-test"
$ 

grep -nr intervall server/{mysql-test,include,storage}

grep -nr uppdate server/{mysql-test,storage}

Comment by Otto Kekäläinen [ 2022-08-31 ]

I pushed the debian/* ones to https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/ce555423817cf8e638296c2387615d6f363b99e2 but ideally all of these would be fixed upstream in MariaDB.

Comment by Eric Lindblad (Inactive) [ 2022-08-31 ]

had the wrong path in my sed command (this is now corrected)

$ grep -nr Fragmnt server
server/debian/additions/mariadb-report:1379:Block Fragmnt @>>>>>%
$ 

the push to debian appears not to have affected the lintian-overrides file

$ grep -nr formated server/debian
server/debian/source/lintian-overrides:66:# Machine formated HTML
$ 

the misspelling as 'formated' appears elsewhere

grep -nr formated server/{mysql-test,storage,sql}

Comment by Daniel Black [ 2022-12-20 ]

Thanks to musvaage the headers and debian directories have been fixed:

"formated"/"uppdate" still remains.

Comment by Daniel Black [ 2022-12-20 ]

Making as closed.

Remaining fixes seem code related.

Although code fixing can be done, its harder especially if a missed change occurs on a later version than the fix resulting in a compile failure which causes more pain than the existing misspelling.

If you fix the latest version, a bug fix later on the earlier version all of a sudden needs a different fix in the latest version if it touches a misspelt word.

If you can be exceptionally meticulous of compiling and running the test suite on all versions you may attempt it, but please don't get it wrong, it consumes time of developers that could be expending fixing more user visible problems.

My current feeling is I'd rather code misspellings be left as is.

Generated at Thu Feb 08 10:07:15 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.