[MDEV-29100] mysqldump: unknown variable 'max-statement-time' when included via --defaults-file or --defaults-extra-file Created: 2022-07-14 Updated: 2022-07-24 Resolved: 2022-07-24 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Scripts & Clients |
| Affects Version/s: | 10.8.3 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Minor |
| Reporter: | Andrew Ryan | Assignee: | Unassigned |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Description |
|
mariadb-dump --help includes:
The documentation for max_statement_time indicates it can be set dynamically for a session. However attempts to set this variable in any of the listed groups result in 'unknown variable' error: eg
Where the client and server are hosted on different servers and the user lacks SUPER, I'm not aware of any workaround available. |
| Comments |
| Comment by Daniel Black [ 2022-07-14 ] |
|
Andrew Ryan, do you want to add the code to set this unconditionally, like mariabackup in I'm happy to take this as a bug fix to 10.3 (and then merge to later branches). |
| Comment by Andrew Ryan [ 2022-07-14 ] |
|
Thanks Daniel. While setting this unconditionally to 0 would suit our scenarios, I wonder whether that may impact/surprise users who rely on the current behaviour and whether it would be inconsistent with the documentation. Eg if a non-0 value configured in my.cnf suddenly became ineffective for mysqldump that seems like a significant behavioural change. If possible, I think it would be safer if the value in the extra file was applied. Given this config currently generates an error, a change to this behaviour shouldn't cause any surprise/break for any user/application. |
| Comment by Daniel Black [ 2022-07-14 ] |
|
I can't think of a case where user's expect partial mariadb-dump contents. What is more likely surprise them in their current state with an incomplete restore. It hasn't surprised mariabackup users enough to create a bug. If I was going for a config option, it would be for a generic init_sql to account for other changes, potentially even reverting a default session max_statement_time=0. |
| Comment by Andrew Ryan [ 2022-07-14 ] |
|
Good point (I just realised we now have to check backups across several hundred servers). Yes, either setting this variable unconditionally or adding a config option would be great. Thanks again. |