Deprecate Spider plugin variables that result in excessive tweak
(MDEV-27228)
|
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - Spider |
| Affects Version/s: | None |
| Fix Version/s: | 10.7.5, 10.8.4, 10.9.2 |
| Type: | Technical task | Priority: | Critical |
| Reporter: | Nayuta Yanagisawa (Inactive) | Assignee: | Nayuta Yanagisawa (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Description |
|
We change the default value of the plugin variable, spider_semi_table_lock, to 0 (no semi-table lock) and then deprecate the variable. Setting the variable to 1 (semi-table lock) would result in poor performance and it is rare to use non-transactional engines these days. Further, maintaining the variable complicates the code. The variable, spider_semi_table_lock_connection, should be too deprecated because it is for tweaking the semi-table locking. See https://mariadb.com/kb/en/spider-server-system-variables/ for the details of the variables. |
| Comments |
| Comment by Nayuta Yanagisawa (Inactive) [ 2022-06-14 ] |
|
The issue is critical because MDEV-28830 is critical. |
| Comment by Nayuta Yanagisawa (Inactive) [ 2022-06-21 ] |
|
holyfoot Please review: https://github.com/MariaDB/server/commit/b501e60a7f140667e7c066d76d0bf8dcf2132951 |
| Comment by Alexey Botchkov [ 2022-06-26 ] |
|
ok to push. |
[MDEV-28829]