[MDEV-28782] mariadb-tzinfo-to-sql to work in bootstrap mode Created: 2022-06-09  Updated: 2023-04-18  Resolved: 2022-06-17

Status: Closed
Project: MariaDB Server
Component/s: Scripts & Clients
Fix Version/s: 10.6.9, 10.7.5, 10.8.4, 10.9.2

Type: Task Priority: Major
Reporter: Daniel Black Assignee: Daniel Black
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-28263 mariadb-tzinfo-to-sql binlog, embedde... Closed
relates to MDEV-28718 bootstrap access to sys_var_slave_par... Open
relates to MDEV-30854 mariadb-tzinfo-to-sql creates sql_mod... Closed

 Description   

https://github.com/MariaDB/server/commit/13e77930e615f05cc74d408110e887b00e1abcc9#commitcomment-75034614 lists the desired functionality.

MDEV-28718 is currently blocking this, but it can be avoided.



 Comments   
Comment by Daniel Lenski [ 2022-07-20 ]

In https://github.com/MariaDB/server/commit/3b662c6ebd26b54ce534d9e7451cdc31e6c0046c, marko made a fixup change to make this work for the "embedded" case:

+let $is_embedded=`select version() like '%embedded%'`;
 
Repeated change:
 
+if ($is_embedded) {
+--replace_column 1 0 2 0
+}
 SELECT @wsrep_is_on,  @wsrep_cannot_replicate_tz, @save_wsrep_on, @save_sql_log_bin, @@SQL_LOG_BIN;

However, there are many other ways to build MariaDB where the @wsrep_is_on and @wsrep_cannot_replicate_tz variables will have the value NULL. It would be much better to have fixed this test in a more robust fashion.

I'd propose:

-let $is_embedded=`select version() like '%embedded%'`;
+let $replace_wsrep_columns=`select version() like '%embedded%' or @wsrep_is_on is NULL`;

Generated at Thu Feb 08 10:03:26 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.