[MDEV-28548] ER_TABLEACCESS_DENIED_ERROR is missing information about DB Created: 2022-05-12 Updated: 2022-09-30 Resolved: 2022-09-30 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Server |
| Affects Version/s: | 10.2, 10.3, 10.4, 10.5, 10.6, 10.7, 10.8, 10.9 |
| Fix Version/s: | 10.3.37, 10.4.27, 10.5.18, 10.6.11, 10.7.7, 10.8.6, 10.9.4, 10.10.2, 10.11.1 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Anel Husakovic | Assignee: | Anel Husakovic |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Description |
|
|
| Comments |
| Comment by Vicențiu Ciorbaru [ 2022-05-31 ] | |||||||||||||||||||||||
|
Hi Anel! Looks like you forgot the null pointer check like I told you here: https://mariadb.zulipchat.com/#narrow/stream/252587-AskMonty/topic/MDEV-28548/near/282130265 Here is my suggestion:
Also, as a stylistic / readability change, can you please rename all occurrences of your String str to be: String db_and_table. Ok to push after this. | |||||||||||||||||||||||
| Comment by Sergei Golubchik [ 2022-06-06 ] | |||||||||||||||||||||||
|
It should be fixed like
1. 'db.table' quoting is always wrong, it doesn't escape characters properly and doesn't produce a valid identifier | |||||||||||||||||||||||
| Comment by Vicențiu Ciorbaru [ 2022-06-06 ] | |||||||||||||||||||||||
|
serg You are right with both points and for point #2 I had considered it, but I wrongly drew the conclusion that we can't change the string message in stable releases. I now realize that this restriction is about adding error messages, not about modifying existing ones. anel note that Serg's proposed patch, which I agree with means you need to update the translation string for all languages to use the "escaping" syntax with 2 identifiers. | |||||||||||||||||||||||
| Comment by Anel Husakovic [ 2022-06-06 ] | |||||||||||||||||||||||
|
Hi, | |||||||||||||||||||||||
| Comment by Anel Husakovic [ 2022-07-16 ] | |||||||||||||||||||||||
| Comment by Vicențiu Ciorbaru [ 2022-07-19 ] | |||||||||||||||||||||||
|
Review done. Please update the patch with the requested changes then send back for review. | |||||||||||||||||||||||
| Comment by Anel Husakovic [ 2022-08-09 ] | |||||||||||||||||||||||
|
PR updated. | |||||||||||||||||||||||
| Comment by Anel Husakovic [ 2022-09-30 ] | |||||||||||||||||||||||
|
Pushed with commit 1f51d6c0f65 to 10.3. |