[MDEV-28236] Allow wsrep_sst_rsync to pass options to rsync binary via [sst] settings Created: 2022-04-04  Updated: 2022-04-18

Status: Open
Project: MariaDB Server
Component/s: Galera, Galera SST
Fix Version/s: None

Type: Task Priority: Major
Reporter: Hartmut Holzgraefe Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-4221 Either add wsrep_sst_rsync_wan to the... Closed
relates to MDEV-11036 Add link wsrep_sst_rsync_wan -> wsrep... Closed

 Description   

Currently the wsrep_sst_rsync script is symlinked to wsrep_sst_rsync_wan, with the script checking which name it was called by, and adding the --whole-file when not seeing wan in the $0 command name variable.

This is sort of magic, and not documented beyond having a minimal man page just saying

WSREP_SST_RSYNC_WAN(1)         MariaDB Database System        WSREP_SST_RSYNC_WAN(1)
 
NAME
       wsrep_sst_rsync_wan - rsync_wan (rsync with delta transfers)-based state
       snapshot transfer
 
DESCRIPTION
       Use: rsync_wan-based state snapshot transfer.
 
       For more information, please refer to the MariaDB Knowledge Base, available
       online at https://mariadb.com/kb/
 
MariaDB 10.6                         15 May 2020              WSREP_SST_RSYNC_WAN(1)

I'd suggest to have a [sst] parameter like e.g. rsync_wan, and maybe also a generic rsync_options instead to be able to have all configuration settings in one place.

And of course: document it properly ...


Generated at Thu Feb 08 09:59:08 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.