[MDEV-28136] MariaDB ASAN Unknown Crash in Item_func_to_char::parse_format_string Created: 2022-03-21  Updated: 2023-11-28

Status: Confirmed
Project: MariaDB Server
Component/s: None
Affects Version/s: 10.9.0, 10.6, 10.7, 10.8, 10.9, 10.10, 10.11, 11.0, 11.1, 11.2
Fix Version/s: 10.6, 10.11, 11.0, 11.1, 11.2

Type: Bug Priority: Major
Reporter: Jingzhou Fu Assignee: Michael Widenius
Resolution: Unresolved Votes: 0
Labels: None
Environment:

Linux jie-2 5.4.143-1-pve #1 SMP PVE 5.4.143-1 (Tue, 28 Sep 2021 09:10:37 +0200) x86_64 x86_64 x86_64 GNU/Linux

Issue Links:
Relates
relates to MDEV-20017 Implement TO_CHAR() Oracle compatible... Closed
relates to MDEV-26814 UBSAN: runtime error: applying non-ze... Confirmed

 Description   

PoC:

CREATE TABLE maximum_value(
 
  start_value int NOT NULL, increment int NOT NULL, cache_size varchar(1) NOT NULL,
 
  PRIMARY KEY (start_value), INDEX maximum_value (cache_size, increment)
 
) ENGINE=ARIA;
 
INSERT INTO maximum_value VALUES 
  (1,9,'x'), (2,5,'g'), (3,1,'o'), (4,0,'g'), (5,1,'cache_size'),
 
  (6,190,'cache_size'), (7,6,'x'), (8,3,'c'), (9,4,'z'), (10,3,'increment'),
 
  (11,186,'x'), (12,1,'g'), (13,8,'q'), (14,226,'cache_size'), (15,133,'p');
 
select to_char('2000-11-11', cache_size) from maximum_value;

report (compiled with ASAN):

=================================================================
 
==3729==ERROR: AddressSanitizer: unknown-crash on address 0x619000065eda at pc 0x0000019c0bc8 bp 0x7f1f3b4ddf30 sp 0x7f1f3b4ddf28
 
READ of size 1 at 0x619000065eda thread T17
 
    #0 0x19c0bc7 in Item_func_tochar::parse_format_string(String const*, unsigned int*) /root/mariadb/sql/item_timefunc.cc:2176:18
 
    #1 0x19c2a49 in Item_func_tochar::val_str(String*) /root/mariadb/sql/item_timefunc.cc:2704:9
 
    #2 0x1335e49 in Type_handler::Item_send_str(Item*, Protocol*, st_value*) const /root/mariadb/sql/sql_type.cc:7468:19
 
    #3 0x920511 in Protocol::send_result_set_row(List<Item>*) /root/mariadb/sql/protocol.cc:1328:15
 
    #4 0xaf9409 in select_send::send_data(List<Item>&) /root/mariadb/sql/sql_class.cc:3060:17
 
    #5 0xdb5094 in select_result_sink::send_data_with_check(List<Item>&, st_select_lex_unit*, unsigned long long) /root/mariadb/sql/sql_class.h:5612:12
 
    #6 0xdb5094 in end_send(JOIN*, st_join_table*, bool) /root/mariadb/sql/sql_select.cc:22331:9
 
    #7 0xe315ff in evaluate_join_record(JOIN*, st_join_table*, int) /root/mariadb/sql/sql_select.cc:21325:11
 
    #8 0xd4c23d in sub_select(JOIN*, st_join_table*, bool) /root/mariadb/sql/sql_select.cc:21134:9
 
    #9 0xdc6797 in do_select(JOIN*, Procedure*) /root/mariadb/sql/sql_select.cc:20640:14
 
    #10 0xdc6797 in JOIN::exec_inner() /root/mariadb/sql/sql_select.cc:4749:50
 
    #11 0xdc344c in JOIN::exec() /root/mariadb/sql/sql_select.cc:4527:3
 
    #12 0xd4e4e8 in mysql_select(THD*, TABLE_LIST*, List<Item>&, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, unsigned long long, select_result*, st_select_lex_unit*, st_select_lex*) /root/mariadb/sql/sql_select.cc:5007:9
 
    #13 0xd4d74b in handle_select(THD*, LEX*, select_result*, unsigned long) /root/mariadb/sql/sql_select.cc:543:10
 
    #14 0xc74410 in execute_sqlcom_select(THD*, TABLE_LIST*) /root/mariadb/sql/sql_parse.cc:6252:12
 
    #15 0xc609c9 in mysql_execute_command(THD*, bool) /root/mariadb/sql/sql_parse.cc:3943:12
 
    #16 0xc4a67e in mysql_parse(THD*, char*, unsigned int, Parser_state*) /root/mariadb/sql/sql_parse.cc:8027:18
 
    #17 0xc41ba9 in dispatch_command(enum_server_command, THD*, char*, unsigned int, bool) /root/mariadb/sql/sql_parse.cc:1894:7
 
    #18 0xc4b74b in do_command(THD*, bool) /root/mariadb/sql/sql_parse.cc:1402:17
 
    #19 0x111f9f2 in do_handle_one_connection(CONNECT*, bool) /root/mariadb/sql/sql_connect.cc:1418:11
 
    #20 0x111f248 in handle_one_connection /root/mariadb/sql/sql_connect.cc:1312:5
 
    #21 0x1f3f9dd in pfs_spawn_thread /root/mariadb/storage/perfschema/pfs.cc:2201:3
 
    #22 0x7f1f622a1608 in start_thread /build/glibc-sMfBJT/glibc-2.31/nptl/pthread_create.c:477:8
 
    #23 0x7f1f61fb7162 in clone /build/glibc-sMfBJT/glibc-2.31/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95
 
 
 
0x619000065eda is located 90 bytes inside of 1040-byte region [0x619000065e80,0x619000066290)
 
allocated by thread T17 here:
 
    #0 0x80f99d in malloc (/usr/local/mysql/bin/mariadbd+0x80f99d)
 
    #1 0x2a76878 in my_malloc /root/mariadb/mysys/my_malloc.c:90:29
 
    #2 0x2a5887f in root_alloc /root/mariadb/mysys/my_alloc.c:66:10
 
    #3 0x2a5887f in alloc_root /root/mariadb/mysys/my_alloc.c:332:29
 
    #4 0x2a5a13a in strmake_root /root/mariadb/mysys/my_alloc.c:584:12
 
    #5 0x104b928 in open_table_from_share(THD*, TABLE_SHARE*, st_mysql_const_lex_string const*, unsigned int, unsigned int, unsigned int, TABLE*, bool, List<String>*) /root/mariadb/sql/table.cc:4033:20
 
    #6 0xa8ccd2 in open_table(THD*, TABLE_LIST*, Open_table_context*) /root/mariadb/sql/sql_base.cc:2003:12
 
    #7 0xa98133 in open_and_process_table(THD*, TABLE_LIST*, unsigned int*, unsigned int, Prelocking_strategy*, bool, Open_table_context*) /root/mariadb/sql/sql_base.cc:3809:14
 
    #8 0xa98133 in open_tables(THD*, DDL_options_st const&, TABLE_LIST**, unsigned int*, unsigned int, Prelocking_strategy*) /root/mariadb/sql/sql_base.cc:4292:14
 
    #9 0xaa1ff6 in open_and_lock_tables(THD*, DDL_options_st const&, TABLE_LIST*, bool, unsigned int, Prelocking_strategy*) /root/mariadb/sql/sql_base.cc:5265:7
 
    #10 0xb656a1 in open_and_lock_tables(THD*, TABLE_LIST*, bool, unsigned int) /root/mariadb/sql/sql_base.h:509:10
 
    #11 0xb656a1 in mysql_insert(THD*, TABLE_LIST*, List<Item>&, List<List<Item> >&, List<Item>&, List<Item>&, enum_duplicates, bool, select_result*) /root/mariadb/sql/sql_insert.cc:758:9
 
    #12 0xc68510 in mysql_execute_command(THD*, bool) /root/mariadb/sql/sql_parse.cc:4562:10
 
    #13 0xc4a67e in mysql_parse(THD*, char*, unsigned int, Parser_state*) /root/mariadb/sql/sql_parse.cc:8027:18
 
    #14 0xc41ba9 in dispatch_command(enum_server_command, THD*, char*, unsigned int, bool) /root/mariadb/sql/sql_parse.cc:1894:7
 
    #15 0xc4b74b in do_command(THD*, bool) /root/mariadb/sql/sql_parse.cc:1402:17
 
    #16 0x111f9f2 in do_handle_one_connection(CONNECT*, bool) /root/mariadb/sql/sql_connect.cc:1418:11
 
    #17 0x111f248 in handle_one_connection /root/mariadb/sql/sql_connect.cc:1312:5
 
    #18 0x1f3f9dd in pfs_spawn_thread /root/mariadb/storage/perfschema/pfs.cc:2201:3
 
    #19 0x7f1f622a1608 in start_thread /build/glibc-sMfBJT/glibc-2.31/nptl/pthread_create.c:477:8
 
 
 
Thread T17 created by T0 here:
 
    #0 0x7f9cfc in pthread_create (/usr/local/mysql/bin/mariadbd+0x7f9cfc)
 
    #1 0x1f3fd39 in my_thread_create(unsigned long*, pthread_attr_t const*, void* (*)(void*), void*) /root/mariadb/storage/perfschema/my_thread.h:52:10
 
    #2 0x1f3fd39 in pfs_spawn_thread_v1 /root/mariadb/storage/perfschema/pfs.cc:2252:15
 
    #3 0x85cef4 in inline_mysql_thread_create(unsigned int, unsigned long*, pthread_attr_t const*, void* (*)(void*), void*) /root/mariadb/include/mysql/psi/mysql_thread.h:1139:11
 
    #4 0x85cef4 in create_thread_to_handle_connection(CONNECT*) /root/mariadb/sql/mysqld.cc:5975:19
 
    #5 0x85e72a in create_new_thread(CONNECT*) /root/mariadb/sql/mysqld.cc:6034:3
 
    #6 0x85e72a in handle_accepted_socket(st_mysql_socket, st_mysql_socket) /root/mariadb/sql/mysqld.cc:6096:5
 
    #7 0x85a34c in handle_connections_sockets() /root/mariadb/sql/mysqld.cc:6220:9
 
    #8 0x84e9ef in mysqld_main(int, char**) /root/mariadb/sql/mysqld.cc:5870:3
 
    #9 0x7f1f61ebc0b2 in __libc_start_main /build/glibc-sMfBJT/glibc-2.31/csu/../csu/libc-start.c:308:16
 
 
 
SUMMARY: AddressSanitizer: unknown-crash /root/mariadb/sql/item_timefunc.cc:2176:18 in Item_func_tochar::parse_format_string(String const*, unsigned int*)
 
Shadow bytes around the buggy address:
 
  0x0c3280004b80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 
  0x0c3280004b90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 
  0x0c3280004ba0: 00 00 00 00 00 00 fa fa fa fa fa fa fa fa fa fa
 
  0x0c3280004bb0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
 
  0x0c3280004bc0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
 
=>0x0c3280004bd0: 00 00 00 00 00 00 f7 00 06 f7 00[02]00 02 f7 00
 
  0x0c3280004be0: 00 00 00 f7 00 00 00 00 00 00 00 00 00 00 f7 00
 
  0x0c3280004bf0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 
  0x0c3280004c00: 00 00 00 00 00 00 00 00 00 f7 00 00 00 00 00 00
 
  0x0c3280004c10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 
  0x0c3280004c20: 00 00 00 00 f7 00 00 00 00 00 00 00 00 00 00 00
 
Shadow byte legend (one shadow byte represents 8 application bytes):
 
  Addressable:           00
 
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
 
  Freed heap region:       fd
 
  Stack left redzone:      f1
 
  Stack mid redzone:       f2
 
  Stack right redzone:     f3
 
  Stack after return:      f5
 
  Stack use after scope:   f8
 
  Global redzone:          f9
 
  Global init order:       f6
 
  Poisoned by user:        f7
 
  Container overflow:      fc
 
  Array cookie:            ac
 
  Intra object redzone:    bb
 
  ASan internal:           fe
 
  Left alloca redzone:     ca
 
  Right alloca redzone:    cb
 
  Shadow gap:              cc
 
==3729==ABORTING



 Comments   
Comment by Alice Sherepa [ 2022-03-21 ]

Thank you!
I repeated on 10.6-10.8:

CREATE TABLE t1( a varchar(1)) ;
 
INSERT INTO t1 VALUES ('p');
 
select to_char('2000-11-11', a) from t1;

On non-debug build - function returns NULL and Warning (Code 3047): Invalid argument error: date format not recognized at p in function to_char.

10.6 8840583a92243f6ac543689

 
Version: '10.6.8-MariaDB-debug-log'  
=================================================================
 
==192677==ERROR: AddressSanitizer: unknown-crash on address 0x6190000d713b at pc 0x560430b17938 bp 0x7f52470a7500 sp 0x7f52470a74f0
 
READ of size 1 at 0x6190000d713b thread T11
 
    #0 0x560430b17937 in Item_func_tochar::parse_format_string(String const*, unsigned int*) /10.6/src/sql/item_timefunc.cc:2176
 
    #1 0x560430b1be78 in Item_func_tochar::val_str(String*) /10.6/src/sql/item_timefunc.cc:2704
 
    #2 0x56043060ac63 in Type_handler::Item_send_str(Item*, Protocol*, st_value*) const /10.6/src/sql/sql_type.cc:7468
 
    #3 0x56043040011b in Type_handler_string_result::Item_send(Item*, Protocol*, st_value*) const /10.6/src/sql/sql_type.h:5454
 
    #4 0x56042fd220e5 in Item::send(Protocol*, st_value*) /10.6/src/sql/item.h:1227
 
    #5 0x56042fd128b4 in Protocol::send_result_set_row(List<Item>*) /10.6/src/sql/protocol.cc:1328
 
    #6 0x56042fec30bf in select_send::send_data(List<Item>&) /10.6/src/sql/sql_class.cc:3125
 
    #7 0x56043019114a in select_result_sink::send_data_with_check(List<Item>&, st_select_lex_unit*, unsigned long long) /10.6/src/sql/sql_class.h:5636
 
    #8 0x56043014a877 in end_send /10.6/src/sql/sql_select.cc:22337
 
    #9 0x56043013ea84 in do_select /10.6/src/sql/sql_select.cc:20585
 
    #10 0x5604300cb529 in JOIN::exec_inner() /10.6/src/sql/sql_select.cc:4753
 
    #11 0x5604300c8a29 in JOIN::exec() /10.6/src/sql/sql_select.cc:4531
 
    #12 0x5604300ccf7c in mysql_select(THD*, TABLE_LIST*, List<Item>&, Item*, unsigned int, st_order*, st_order*, Item*, st_order*, unsigned long long, select_result*, st_select_lex_unit*, st_select_lex*) /10.6/src/sql/sql_select.cc:5010
 
    #13 0x56043009d2c4 in handle_select(THD*, LEX*, select_result*, unsigned long) /10.6/src/sql/sql_select.cc:545
 
    #14 0x5604300022d0 in execute_sqlcom_select /10.6/src/sql/sql_parse.cc:6255
 
    #15 0x56042fff0e76 in mysql_execute_command(THD*, bool) /10.6/src/sql/sql_parse.cc:3945
 
    #16 0x56043000d593 in mysql_parse(THD*, char*, unsigned int, Parser_state*) /10.6/src/sql/sql_parse.cc:8029
 
    #17 0x56042ffe377c in dispatch_command(enum_server_command, THD*, char*, unsigned int, bool) /10.6/src/sql/sql_parse.cc:1896
 
    #18 0x56042ffe04a0 in do_command(THD*, bool) /10.6/src/sql/sql_parse.cc:1404
 
    #19 0x56043044829c in do_handle_one_connection(CONNECT*, bool) /10.6/src/sql/sql_connect.cc:1418
 
    #20 0x560430447b28 in handle_one_connection /10.6/src/sql/sql_connect.cc:1312
 
    #21 0x56043116dfc1 in pfs_spawn_thread /10.6/src/storage/perfschema/pfs.cc:2201
 
    #22 0x7f5255f35608 in start_thread /build/glibc-sMfBJT/glibc-2.31/nptl/pthread_create.c:477
 
    #23 0x7f5255b06162 in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x11f162)
 
 
 
0x6190000d713b is located 187 bytes inside of 1124-byte region [0x6190000d7080,0x6190000d74e4)
 
allocated by thread T11 here:
 
    #0 0x7f52564c0808 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:144
 
    #1 0x560431db7827 in sf_malloc /10.6/src/mysys/safemalloc.c:126
 
    #2 0x560431d84a4e in my_malloc /10.6/src/mysys/my_malloc.c:90
 
    #3 0x560431d60953 in alloc_root /10.6/src/mysys/my_alloc.c:244
 
    #4 0x560431d61fb8 in strmake_root /10.6/src/mysys/my_alloc.c:466
 
    #5 0x560430364854 in open_table_from_share(THD*, TABLE_SHARE*, st_mysql_const_lex_string const*, unsigned int, unsigned int, unsigned int, TABLE*, bool, List<String>*) /10.6/src/sql/table.cc:4018
 
    #6 0x56042fe4877d in open_table(THD*, TABLE_LIST*, Open_table_context*) /10.6/src/sql/sql_base.cc:2003
 
    #7 0x56042fe5232a in open_and_process_table /10.6/src/sql/sql_base.cc:3809
 
    #8 0x56042fe54f8e in open_tables(THD*, DDL_options_st const&, TABLE_LIST**, unsigned int*, unsigned int, Prelocking_strategy*) /10.6/src/sql/sql_base.cc:4292
 
    #9 0x56042fe5a161 in open_and_lock_tables(THD*, DDL_options_st const&, TABLE_LIST*, bool, unsigned int, Prelocking_strategy*) /10.6/src/sql/sql_base.cc:5265
 
    #10 0x56042fdb12f7 in open_and_lock_tables(THD*, TABLE_LIST*, bool, unsigned int) /10.6/src/sql/sql_base.h:509
 
    #11 0x56042ff27636 in mysql_insert(THD*, TABLE_LIST*, List<Item>&, List<List<Item> >&, List<Item>&, List<Item>&, enum_duplicates, bool, select_result*) /10.6/src/sql/sql_insert.cc:757
 
    #12 0x56042fff4e23 in mysql_execute_command(THD*, bool) /10.6/src/sql/sql_parse.cc:4564
 
    #13 0x56043000d593 in mysql_parse(THD*, char*, unsigned int, Parser_state*) /10.6/src/sql/sql_parse.cc:8029
 
    #14 0x56042ffe377c in dispatch_command(enum_server_command, THD*, char*, unsigned int, bool) /10.6/src/sql/sql_parse.cc:1896
 
    #15 0x56042ffe04a0 in do_command(THD*, bool) /10.6/src/sql/sql_parse.cc:1404
 
    #16 0x56043044829c in do_handle_one_connection(CONNECT*, bool) /10.6/src/sql/sql_connect.cc:1418
 
    #17 0x560430447b28 in handle_one_connection /10.6/src/sql/sql_connect.cc:1312
 
    #18 0x56043116dfc1 in pfs_spawn_thread /10.6/src/storage/perfschema/pfs.cc:2201
 
    #19 0x7f5255f35608 in start_thread /build/glibc-sMfBJT/glibc-2.31/nptl/pthread_create.c:477
 
 
 
Thread T11 created by T0 here:
 
    #0 0x7f52563ed815 in __interceptor_pthread_create ../../../../src/libsanitizer/asan/asan_interceptors.cc:208
 
    #1 0x560431169ba8 in my_thread_create /10.6/src/storage/perfschema/my_thread.h:52
 
    #2 0x56043116e3b4 in pfs_spawn_thread_v1 /10.6/src/storage/perfschema/pfs.cc:2252
 
    #3 0x56042fccbc18 in inline_mysql_thread_create /10.6/src/include/mysql/psi/mysql_thread.h:1139
 
    #4 0x56042fce34c9 in create_thread_to_handle_connection(CONNECT*) /10.6/src/sql/mysqld.cc:5934
 
    #5 0x56042fce3b45 in create_new_thread(CONNECT*) /10.6/src/sql/mysqld.cc:5993
 
    #6 0x56042fce3eb2 in handle_accepted_socket(st_mysql_socket, st_mysql_socket) /10.6/src/sql/mysqld.cc:6055
 
    #7 0x56042fce489f in handle_connections_sockets() /10.6/src/sql/mysqld.cc:6179
 
    #8 0x56042fce2cd6 in mysqld_main(int, char**) /10.6/src/sql/mysqld.cc:5829
 
    #9 0x56042fccaf3c in main /10.6/src/sql/main.cc:34
 
    #10 0x7f5255a0b0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x240b2)

Generated at Thu Feb 08 09:58:21 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.