[MDEV-27892] Improve ERROR 1476 message Created: 2022-02-19  Updated: 2022-05-24  Resolved: 2022-05-10

Status: Closed
Project: MariaDB Server
Component/s: Server
Affects Version/s: 10.7, 10.8, 10.9
Fix Version/s: 10.5.17, 10.6.9, 10.7.4, 10.8.3, 10.9.1

Type: Bug Priority: Minor
Reporter: Roel Van de Paar Assignee: Nayuta Yanagisawa (Inactive)
Resolution: Fixed Votes: 0
Labels: None


 Description   

ERROR 1476 (HY000) at line 2: The foreign server, d, you are trying to create already exists

To:

ERROR 1476 (HY000) at line 2: Cannot create foreign server 'd' as it already exists



 Comments   
Comment by Nayuta Yanagisawa (Inactive) [ 2022-02-20 ]

What one needs to do is to update errmsg-utf8.txt and related tests.

ER_FOREIGN_SERVER_EXISTS
  eng "The foreign server, %s, you are trying to create already exists"
  ger "Der entfernte Server %s, den Sie versuchen zu erzeugen, existiert schon"
  spa "El servidor foráneo %s que intenta crear ya existe"

Comment by Roel Van de Paar [ 2022-02-20 ]

Thank you. We may as well improve it further at the same time.

ER_FOREIGN_SERVER_EXISTS
  eng "Cannot create foreign server '%s' as it already exists"
  ger "Der auswärtige Server '%s' kann nicht erstellt werden, da er bereits vorhanden ist"
  spa "No se puede crear el servidor externo '%s' porque ya existe"
  ita "Impossibile creare il server esterno '%s' poiché esiste già"
  fre "Impossible de créer le serveur étranger '%s' car il existe déjà"
  jap "外部サーバー '%s'は既に存在するため、作成できません"
  dut "Kan geen externe server '%s' maken omdat deze al bestaat"
  rus "Невозможно создать сторонний сервер '%s', так как он уже существует"
  pol "Nie można utworzyć obcego serwera '%s', ponieważ już istnieje"
  fin "Vieraata palvelinta '%s' ei voida luoda, koska se on jo olemassa "
  nor "Kan ikke opprette utenlandsk server '%s' fordi den allerede eksisterer"
  por "Não foi possível criar o servidor externo '%s' porque ele já existe"
  gre "Δεν είναι δυνατή η δημιουργία ξένου διακομιστή '%s' επειδή υπάρχει ήδη"
  swe "Det gick inte att skapa främmande server '%s' eftersom den redan finns"
  chi "无法创建外部服务器'%s',因为它已经存在"

I added some extra languages, please check that the 3 letter language codes (other than the first three) are correct.

Comment by Norio Akagi [ 2022-05-08 ]

I pushed a pull request https://github.com/MariaDB/server/pull/2113/ (still being a draft), but have a question.

Does "fin" represent Finland above ? I left it as is in my PR, but did not find any other messages associated to "fin". So I wasn't sure if we support the language.

Please let me know if I need to modify the abbreviation.

Comment by Daniel Black [ 2022-05-08 ]

Codes are from iso639-2 (B if applicable) (offline currently, comically due to database error).

While google recognizes it as Finish, this isn't a language in the top of the file, in sql/share/CMakeLists.txt, or debian/mariadb-server-core*.install. I thinking leaving a translation of a single error there in the txt file only is a good move.

Please re-record main.ps_missed_cmds main.create_drop_binlog main.create_drop_server tests per the CI results.

Comment by Roel Van de Paar [ 2022-05-09 ]

To clarify after internal discussion; we intend to add as many languages as possible.

Comment by Norio Akagi [ 2022-05-09 ]

Thanks, then I will leave fin. Let me know if I need to make any other changes to list fin here. (e.g. Don't I need to add it in the 1st line in errmsg-utf8.txt)

The pull request is now green, can you check it ? @Daniel

Comment by Roel Van de Paar [ 2022-05-10 ]

Not sure on any language codes from my side. Please check that the 3 letter language codes (other than the first three) are correct.

Comment by Nayuta Yanagisawa (Inactive) [ 2022-05-10 ]

https://github.com/MariaDB/server/commit/488e56b50c40f3577dc09ae61f9970d86bcb6c64

Comment by Daniel Black [ 2022-05-24 ]

FYI I did the 10.5, 10.6 backports after the release which is why it isn't a usual set of release date compatible fixed versions.

Generated at Thu Feb 08 09:56:23 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.