[MDEV-2782] LP:600744 - XtraDB compile error with VS 10 64-bit Created: 2010-07-02  Updated: 2015-02-02  Resolved: 2012-10-04

Status: Closed
Project: MariaDB Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Hakan Küçükyılmaz (Inactive) Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: Launchpad

Attachments: XML File LPexportBug600744.xml     Text File LPexportBug600744_fix-600744.patch     Text File LPexportBug600744_fix-600744.patch     Text File LPexportBug600744_fix-600744.patch    

 Description   

Compiling XtraDB with VS 2010 on 64-bit Windows fails with several errors all of the type:

Error 10 error C2440: 'initializing' : cannot convert from 'ulint *' to 'unsigned long *' C:\Users\hakan\work\monty_program\maria-5.2\storage\xtradb\handler\ha_innodb.cc 10410

The code in question is:

Error 10 error C2440: 'initializing' : cannot convert from 'ulint *' to 'unsigned long *' C:\Users\hakan\work\monty_program\maria-5.2\storage\xtradb\handler\ha_innodb.cc 10410

static MYSQL_SYSVAR_ULONG(use_purge_thread, srv_use_purge_thread,
PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_READONLY,
"Number of purge devoted threads. #### over 1 is EXPERIMENTAL ####",
NULL, NULL, 1, 0, 64, 0);

And line 10410 is
NULL, NULL, 1, 0, 64, 0);

 Comments   
Comment by Bo Thorsen (Inactive) [ 2010-07-02 ]

Re: XtraDB compile error with VS 10 64-bit
The problem is that xtradb tries to store a ulint using unsigned long. This works on all architecures except 64 bit Windows because ulint is defined as __int64 on that. There is currently no MYSQL_SYSVAR_xx that matches this, so I have added a MYSQL_SYSVAR_ULINT and changed the calls to this. See the attached patch.

Comment by Bo Thorsen (Inactive) [ 2010-07-02 ]

The problem is that xtradb tries to store a ulint using unsigned long. This works on all architecures except 64 bit Windows because ulint is defined as __int64 on that. There is currently no MYSQL_SYSVAR_xx that matches this, so I have added a MYSQL_SYSVAR_ULINT and changed the calls to this. See the attached patch.
fix-600744.patch
LPexportBug600744_fix-600744.patch

Comment by Bo Thorsen (Inactive) [ 2010-07-02 ]

Re: XtraDB compile error with VS 10 64-bit
New attempt at a patch. This one doesn't modify plugin.h but is local to xtradb.

Comment by Bo Thorsen (Inactive) [ 2010-07-02 ]

New attempt at a patch. This one doesn't modify plugin.h but is local to xtradb.
fix-600744.patch
LPexportBug600744_fix-600744.patch

Comment by Bo Thorsen (Inactive) [ 2010-07-02 ]

Re: XtraDB compile error with VS 10 64-bit
Here is a smaller patch, which is the one I'll push to MariaDB.

Comment by Bo Thorsen (Inactive) [ 2010-07-02 ]

Here is a smaller patch, which is the one I'll push to MariaDB.
fix-600744.patch
LPexportBug600744_fix-600744.patch

Comment by Rasmus Johansson (Inactive) [ 2011-06-07 ]

Launchpad bug id: 600744

Comment by Stewart Smith [ 2011-06-07 ]

Re: XtraDB compile error with VS 10 64-bit
All development of XtraDB has moved under the Percona Server project - https://launchpad.net/percona-server - If this bug can be reproduced against current Percona Server, please file this bug against percona-server (you can simply do so by using the "Also affects project" link above).

Thanks,
Stewart Smith
Director of Server Development
Percona.

Generated at Thu Feb 08 06:44:11 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.