Various small mysqldump manual improvements for the --as-of and --tz-utc options
(MDEV-26946)
|
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Scripts & Clients, Versioned Tables |
| Affects Version/s: | 10.7, 10.8 |
| Fix Version/s: | 10.7.4, 10.8.3 |
| Type: | Technical task | Priority: | Critical |
| Reporter: | Roel Van de Paar | Assignee: | Aleksey Midenkov |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
Implement binary changes enumerated in MDEV-26946 Proposed texts as per MDEV-26946:
|
| Comments |
| Comment by Aleksey Midenkov [ 2022-02-09 ] | |||||
|
--help is not the man page. --help briefly describes what each option does. Brevity is the main feature here: basically it lists what the options are available long and short for the user to interact. When the user wants details he reads the man page. That's the common UNIX practice! If you think differently, please suggest the text for the p.4 and approve this ticket with serg. | |||||
| Comment by Roel Van de Paar [ 2022-02-16 ] | |||||
|
midenok sorry to say, but did you even read the bug report I wrote? A proposed text is/was already there, and is exactly one line longer than the current text. | |||||
| Comment by Aleksey Midenkov [ 2022-02-21 ] | |||||
|
Roel Maybe I read wrong this: 4. The mysqldump binary's help for -as-of should be changed in a similar matter as items 1 to 3 above. So it requires to include this:
Followed by:
Will dump the table structure but not the data. 2. In regards timestamps, the connection with -tz-utc / -skip-tz-utc would best be clarified to make it easier for users to understand why their timestamps are not working when dumping data. Perhaps something like:
---------------- | |||||
| Comment by Aleksey Midenkov [ 2022-02-21 ] | |||||
|
Roel to avoid further misunderstanding please update this task description with exact instructions for this task only. | |||||
| Comment by Roel Van de Paar [ 2022-02-22 ] | |||||
|
midenok Again, the proposed text for --tz-utc was already there and for --as-of I simply used the sentences which were also already there. I've added it into the description above for you. | |||||
| Comment by Roel Van de Paar [ 2022-02-22 ] | |||||
|
midenok serg As mentioned in MDEV-26946, before documenting this, it needs to be validated that it is correct and expected behavior to dump table structures always. i.e. when a user dumps with an --as-of set to 1990 it will dump a table structure created in 2022, even if no data is included. | |||||
| Comment by Sergei Golubchik [ 2022-02-23 ] | |||||
|
yes, as far as table structure is concerned — it's definitely correct and expected. as far as --as-of help text is concerned — I agree that it could benefit from a second statement, like "Timestamp is interpreted according to the --tz-utc setting". | |||||
| Comment by Roel Van de Paar [ 2022-02-25 ] | |||||
|
Updated description to match, thank you! | |||||
| Comment by Aleksey Midenkov [ 2022-03-01 ] | |||||
|
Please review bb-10.7-midenok | |||||
| Comment by Roel Van de Paar [ 2022-03-02 ] | |||||
|
IMHO, the original proposed text above has two advantages not present in the proposed patch; There is also a typo: "versioned table" should read "versioned table(s)" as it can be more than one. | |||||
| Comment by Aleksey Midenkov [ 2022-03-29 ] | |||||
|
Roel We do not specify MDEV references in the UI, do we? | |||||
| Comment by Sergei Golubchik [ 2022-04-10 ] | |||||
|
b8a66d853cb4ba52c0ab09074f34f566ae25bf52 is ok to push, thanks |