[MDEV-27169] Change default values of Spider plugin variables to default values of table variables Created: 2021-12-05 Updated: 2023-10-22 Resolved: 2022-03-14 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - Spider |
| Fix Version/s: | 10.7.4, 10.8.3 |
| Type: | Task | Priority: | Critical |
| Reporter: | Nayuta Yanagisawa (Inactive) | Assignee: | Nayuta Yanagisawa (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Description |
|
Change the default values of the Spider plugin variables from -1 (use table value) to the default table values. Also, deprecate the option value -1 (use table value). For example, the current default plugin value of spider_auto_increment_mode is -1 (use table value) and the current default table value is 0 (normal mode). Thus, the real default value is 0. I do like to remove this indirection (just set the default server value to 0). The default table values are defined in spider_set_connect_info_default(). The following documents should be updated at least (MDEV-26365): Here is the list of the plugin variables whose default values should be updated:
|
| Comments |
| Comment by Nayuta Yanagisawa (Inactive) [ 2022-02-21 ] |
|
holyfoot Please review: https://github.com/MariaDB/server/commit/b5ee3fd11c4077b9a20b8432090d2e6e752f65aa |
| Comment by Nayuta Yanagisawa (Inactive) [ 2022-03-02 ] |
|
I should have updated tests at least. |
| Comment by Nayuta Yanagisawa (Inactive) [ 2022-03-03 ] |
|
holyfoot Please review the following patch: https://github.com/MariaDB/server/commit/781741fef15b79262b69b05a5426090290ad9152 |
| Comment by Nayuta Yanagisawa (Inactive) [ 2022-03-04 ] |
|
I updated the patch. Sorry for repeating myself. |
| Comment by Alexey Botchkov [ 2022-03-13 ] |
|
ok to push. |