[MDEV-27169] Change default values of Spider plugin variables to default values of table variables Created: 2021-12-05  Updated: 2023-10-22  Resolved: 2022-03-14

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Spider
Fix Version/s: 10.7.4, 10.8.3

Type: Task Priority: Critical
Reporter: Nayuta Yanagisawa (Inactive) Assignee: Nayuta Yanagisawa (Inactive)
Resolution: Done Votes: 0
Labels: None

Issue Links:
Blocks
blocks MDEV-27258 Deprecate "use table value" option o... Closed
blocks MDEV-27905 Remove option value '-1' (use table v... Stalled
Problem/Incident
causes MDEV-31524 Spider variables that double as table... Closed
Relates
relates to MDEV-27106 Spider: specify connection to data no... Closed

 Description   

Change the default values of the Spider plugin variables from -1 (use table value) to the default table values. Also, deprecate the option value -1 (use table value).

For example, the current default plugin value of spider_auto_increment_mode is -1 (use table value) and the current default table value is 0 (normal mode). Thus, the real default value is 0. I do like to remove this indirection (just set the default server value to 0).

The default table values are defined in spider_set_connect_info_default().

The following documents should be updated at least (MDEV-26365):

Here is the list of the plugin variables whose default values should be updated:

Variable name Current default value New default value
spider_auto_increment_mode -1 0
spider_bgs_first_read -1 2
spider_bgs_mode -1 0
spider_bgs_second_read -1 100
spider_bka_mode -1 1
spider_bka_table_name_type -1 0
spider_buffer_size -1 16000
spider_bulk_size -1 16000
spider_bulk_update_mode -1 0
spider_bulk_update_size -1 16000
spider_casual_read -1 0
spider_connect_timeout -1 6
spider_crd_bg_mode -1 2
spider_crd_interval -1 51
spider_crd_mode -1 1
spider_crd_sync -1 0
spider_crd_type -1 2
spider_crd_weight -1 2
spider_delete_all_rows_type -1 1
spider_direct_dup_insert -1 0
spider_direct_order_limit -1 9223372036854775807LL
spider_error_read_mode -1 0
spider_error_write_mode -1 0
spider_first_read -1 0
spider_init_sql_alloc_size -1 1024
spider_internal_limit -1 9223372036854775807LL
spider_internal_offset -1 0
spider_internal_optimize -1 0
spider_internal_optimize_local -1 0
spider_load_crd_at_startup -1 1
spider_load_sts_at_startup -1 1
spider_low_mem_read -1 1
spider_max_order -1 32767
spider_multi_split_read -1 100
spider_net_read_timeout -1 600
spider_net_write_timeout -1 600
spider_quick_mode -1 3
spider_quick_page_byte -1 10485760
spider_quick_page_size -1 1024
spider_read_only_mode -1 0
spider_reset_sql_alloc -1 1
spider_second_read -1 0
spider_select_column_mode -1 1
spider_selupd_lock_mode -1 1
spider_semi_split_read -1 2
spider_semi_split_read_limit -1 9223372036854775807LL
spider_semi_table_lock_connection -1 1
spider_skip_default_condition -1 0
spider_skip_parallel_search -1 0
split_read -1 9223372036854775807LL
spider_store_last_crd -1 1
spider_store_last_sts -1 1
spider_strict_group_by -1 1
spider_sts_bg_mode -1 2
spider_sts_interval -1 10
spider_sts_mode -1 1
spider_sts_sync -1 0
spider_use_handler -1 0
spider_use_table_charset -1 1


 Comments   
Comment by Nayuta Yanagisawa (Inactive) [ 2022-02-21 ]

holyfoot Please review: https://github.com/MariaDB/server/commit/b5ee3fd11c4077b9a20b8432090d2e6e752f65aa

Comment by Nayuta Yanagisawa (Inactive) [ 2022-03-02 ]

I should have updated tests at least.

Comment by Nayuta Yanagisawa (Inactive) [ 2022-03-03 ]

holyfoot Please review the following patch: https://github.com/MariaDB/server/commit/781741fef15b79262b69b05a5426090290ad9152

Comment by Nayuta Yanagisawa (Inactive) [ 2022-03-04 ]

I updated the patch. Sorry for repeating myself.

Comment by Alexey Botchkov [ 2022-03-13 ]

ok to push.

Generated at Thu Feb 08 09:50:52 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.