[MDEV-27094] Debug builds include useless InnoDB "disabled" options Created: 2021-11-19  Updated: 2022-04-22  Resolved: 2021-11-19

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.2.2, 10.3.0, 10.4.0, 10.5.0, 10.6.0, 10.7.0
Fix Version/s: 10.7.2, 10.5.16, 10.6.8

Type: Bug Priority: Major
Reporter: Marko Mäkelä Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: debug


 Description   

The following options were introduced in MariaDB 10.2.2 and have little use:

  • innodb_disable_resize_buffer_pool_debug has no effect even in MariaDB 10.2.2. It was introduced in MySQL 5.7.6 and almost entirely removed in MySQL 5.7.12.
  • innodb_page_cleaner_disabled_debug and innodb_master_thread_disabled_debug are only used by the test innodb.redo_log_during_checkpoint that is rather useless.
  • innodb_dict_stats_disabled_debug is only used by that test, and it is redundant because one could simply use innodb_stats_persistent=OFF or CREATE TABLE…STATS_PERSISTENT=0 in the test to achieve the same effect.

 Comments   
Comment by Marko Mäkelä [ 2022-04-22 ]

I applied this debug-only cleanup to 10.5, because the test innodb.redo_log_during_checkpoint would occasionally fail due to the function log_checkpoint() triggering some apparent bug in the DBUG subsystem via safe_mutex. In 10.8, MDEV-14425 should have made the conditions unreachable. In 10.5 log checkpoints are tightly coupled with the single buf_flush_page_cleaner thread. The debug instrumentation is more relevant to 10.2, 10.3, 10.4, where there can be multiple page cleaner threads, and the checkpoints are invoked by yet other threads.

Generated at Thu Feb 08 09:50:17 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.