[MDEV-26896] Enable -Wconversion globally Created: 2021-10-25  Updated: 2021-10-25

Status: Open
Project: MariaDB Server
Component/s: None
Fix Version/s: None

Type: Task Priority: Minor
Reporter: Eric Herman Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-21907 Enable -Wconversion for InnoDB and Ma... Closed

 Description   

Since MDEV-21907 -Wconversion has been enabled for clang and GCC, but only for InnoDB and Mariabackup.

The -Wconversion flag helps improve code quality and helps prevent surprise build errors on Microsoft Windows and 32 bit.



 Comments   
Comment by Eric Herman [ 2021-10-25 ]

From https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

-Wconversion

Warn for implicit conversions that may alter a value. This includes conversions between real and integer, like abs( x ) when x is double; conversions between signed and unsigned, like unsigned ui = -1; and conversions to smaller types, like sqrtf (M_PI). Do not warn for explicit casts like abs ((int) x) and ui = (unsigned) -1, or if the value is not changed by the conversion like in abs (2.0). Warnings about conversions between signed and unsigned integers can be disabled by using -Wno-sign-conversion.

For C+, also warn for confusing overload resolution for user-defined conversions; and conversions that never use a type conversion operator: conversions to void, the same type, a base class or a reference to them. Warnings about conversions between signed and unsigned integers are disabled by default in C+ unless -Wsign-conversion is explicitly enabled.

Warnings about conversion from arithmetic on a small type back to that type are only given with -Warith-conversion.

Generated at Thu Feb 08 09:48:46 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.