[MDEV-26747] improve corruption check for encrypted tables on ALTER IMPORT Created: 2021-10-02 Updated: 2021-11-19 Resolved: 2021-11-17 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Data Definition - Alter Table, Encryption, Storage Engine - InnoDB |
| Affects Version/s: | 10.2, 10.3, 10.4, 10.5, 10.6 |
| Fix Version/s: | 10.2.42, 10.3.33, 10.4.23, 10.5.14, 10.6.6 |
| Type: | Bug | Priority: | Major |
| Reporter: | Eugene Kosov (Inactive) | Assignee: | Eugene Kosov (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
When some page in an encrypted table will be corrupted to have ENCRYPTION_KEY_NOT_ENCRYPTED key the server won't call it a corruption. At least a test case with such specific corruption should be added and probably code need to be fixed too. Namely, fil_space_decrypt() should return dberr_t instead of bool. |
| Comments |
| Comment by Marko Mäkelä [ 2021-11-03 ] |
|
Thank you, this looks mostly good, except that I suspect that this might cause a server crash when importing a suitably corrupted encrypted tablespace. Also, please fix the compilation failure on the 10.4 branch. |