[MDEV-26580] s/mysqld/mariadbd/g Created: 2021-09-10  Updated: 2021-09-29

Status: Open
Project: MariaDB Server
Component/s: Server
Fix Version/s: None

Type: Task Priority: Minor
Reporter: Roel Van de Paar Assignee: Sergei Golubchik
Resolution: Unresolved Votes: 0
Labels: None


 Description   

Error messages still refer to mysqld whilst the binary is mariadbd.

10.7.0 1bc82aaf0a7746c0921a94034aff2d51f0d75cd0

 
2021-09-10  8:26:50 4 [ERROR] mysqld: Table 't' is marked as crashed and should be repaired


$ ls -l bin/mariadbd
 
bin/mariadbd
 
$ ls -l bin/mysqld
 
bin/mysqld -> mariadbd

It may thus make sense (in a feature version like 10.7 or 10.8) to rename mysqld to mariadbd in the code where it makes sense to do so. In current version may not be a good idea as people may have scripts they rely on etc.

monty elenst fyi and for input/thoughts

 Comments   
Comment by Sergei Golubchik [ 2021-09-29 ]

What you likely see if the name of the binary. You invoke it a mysqld — you get error messages with "mysqld". If you invoke it with "MySuperDuperDatabaseServer" — you'll likely get that

Comment by Roel Van de Paar [ 2021-09-29 ]

Confirmed.

10.7.0 d552e092c9f3e20da078d1b62b976f629f73d3a4 (Debug)

 
2021-09-29 20:02:40 4 [ERROR] mariadbd: Table 't' is marked as crashed and should be repaired

There are some other occurrences of mysqld in the code which can be swapped to mariadbd if deemed of interest. Few examples: 

sql/signal_handler.cc:  my_safe_printf_stderr("[ERROR] mysqld got " SIGNAL_FMT " ;\n",sig);
 
storage/innobase/log/log0recv.cc: " mysqld:";
 
client/mysql_plugin.c:  {"mysqld", 'm', "Path to mysqld executable. Example: /sbin/temp1/mysql/bin",   # And a few other occurrences in the same file
 
client/mysqladmin.cc:	  puts("mysqld is alive");   # Idem

To see more of them (58 occurrences in 10.7, a subset of which would be comments rather than end-user messages) one can use a grep similar to:

grep "mysqld " */*.c* */*/*.c* */*/*/*.c* */*/*/*/*.c* */*/*/*/*/*.c* 2>/dev/null | grep -E "\"|'"

Generated at Thu Feb 08 09:46:22 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.