[MDEV-26441] wsrep_sst_mariabackup and friends rely on Linux-isms Created: 2021-08-19  Updated: 2021-09-21  Resolved: 2021-09-21

Status: Closed
Project: MariaDB Server
Component/s: Galera SST
Affects Version/s: 10.2.40, 10.3.31, 10.4.21, 10.5.11, 10.6.4
Fix Version/s: 10.2.41, 10.3.32, 10.4.22, 10.5.13, 10.6.5, 10.7.0

Type: Bug Priority: Major
Reporter: Eirik Øverby Assignee: Julius Goryavsky
Resolution: Fixed Votes: 0
Labels: galera
Environment:

FreeBSD, all current versions


Issue Links:
Relates
relates to MDEV-26360 Using hostnames for MariaBackup SSTs ... Closed

 Description   

Starting from 10.5.11 (and any other release carrying the same version of the affected code), wsrep_sst_mariabackup does not work on FreeBSD. There are two issues affecting us:

  • reliance on --tmpdir option to mktemp
  • is_local_ip always returns true in a jail

The former makes the SST script fail because of invalid option.
This is easily (and probably compatible with Linux) fixed by removing the --tmpdir option and rather prefixing mktemp with 'TMPDIR=$tmpdir ;' inside the same $() around line 935 of wsrep_sst_mariabackup:
< xtmpdir=$(mktemp '-d' --tmpdir "$tmpdir")
> xtmpdir=$(TMPDIR="$tmpdir" ; mktemp '-d')

The latter I had to hack by removing the commonname option passed to socat on line 387 of the same file:
< CN_option='localhost'
> CN_option=''

This is obviously not a fix, as I don't fully understand what's going on - but I did not have more time to spend on this as our cluster was down at the time.



 Comments   
Comment by Jan Lindström (Inactive) [ 2021-09-20 ]

ok to push when bb is green

Comment by Julius Goryavsky [ 2021-09-21 ]

Linux dependency fixed: https://github.com/MariaDB/server/commit/f4d6d01782ad4c885f1a4041514ba58f7b7d4ad2

The part that deals with CN will be changed in another MDEV

Generated at Thu Feb 08 09:45:20 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.