[MDEV-26269] Rename sst_dump to mysql_sst_dump / mariadb-sst-dump Created: 2021-07-28  Updated: 2023-04-27

Status: Open
Project: MariaDB Server
Component/s: Packaging, Storage Engine - RocksDB
Affects Version/s: 10.2, 10.3, 10.4, 10.5, 10.6
Fix Version/s: 10.4, 10.5, 10.6

Type: Bug Priority: Major
Reporter: Elena Stepanova Assignee: Sergei Golubchik
Resolution: Unresolved Votes: 0
Labels: None

Issue Links:
Relates

 Description   

As have been already mentioned in several bug reports, there is a potential conflict between mariadb-plugin-rocksdb package and rocksdb-tools package which can be found in some distributions. Both of them contain sst_dump binary, so the packages cannot be installed side-by-side.

There have been attempts to resolve the issue, e.g. within MDEV-14918, by including sst_dump binary into the package conditionally, only when rocksdb-tools cannot be found during the build. However it doesn't eliminate the problem completely, because there can be different repository configuration on the build machine and on an end user's machine. For example, the user can install rocksdb-tools package from backports, and then installation of the MariaDB package will still fail.

To avoid this, in addition to this conditional logic, sst_dump binary should be renamed to a more uniform mysql_sst_dump or mariadb-sst-dump, depending on the server version. It was already suggested before, even in the same MDEV-14918, but had never been done. Another auxiliary library ldb, which comes with the same MariaDB package, was already renamed.

After renaming the debian packaging should be adjusted so that the right name appears on the install/not-installed lists. MTR tests also need to be fixed to refer to the new name.



 Comments   
Comment by Alexey Bychko (Inactive) [ 2021-07-29 ]

just a small correction. if binary is renamed - we can record it in regular debian install files and drop rocksdb-tools part from autobake.sh.
my fix to autobake.sh is rather generic, to do not count packages from backports as really available.

Comment by Elena Stepanova [ 2021-07-29 ]

Indeed. While rocksdb-tools contains a few more binaries, apparently it was made a dependency solely for the sake of avoiding a conflict with sst_dump. So, once sst_dump is renamed in the MariaDB package, we can get rid of the dependency altogether.

Comment by Sergei Golubchik [ 2021-08-07 ]

discussions are still on-going, may be we shouldn't rename it after all.

Generated at Thu Feb 08 09:44:01 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.