[MDEV-25715] Building failure on MacOS 11.3.1 with Connect engine Created: 2021-05-18  Updated: 2021-05-18  Resolved: 2021-05-18

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Connect
Affects Version/s: 10.2, 10.3
Fix Version/s: 10.6.1, 10.2.39, 10.3.30, 10.4.20, 10.5.11

Type: Bug Priority: Major
Reporter: Alice Sherepa Assignee: Olivier Bertrand
Resolution: Fixed Votes: 0
Labels: None


 Description   

10.2 b9a2e4609f93f2cab253f0

CONNECT engine:
/git/10.2/storage/connect/jsonudf.cpp:5946:19: error: address of array 'g->Message' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                PUSH_WARNING(g->Message ? g->Message : "Unexpected error");
                             ~~~^~~~~~~ ~
/git/10.2/storage/connect/jsonudf.cpp:24:86: note: expanded from macro 'PUSH_WARNING'
#define PUSH_WARNING(M) push_warning(current_thd, Sql_condition::WARN_LEVEL_WARN, 0, M)
                                                                                     ^
/git/10.2/storage/connect/jsonudf.cpp:6074:10: error: address of array 'g->Message' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                if (g->Message)
                ~~  ~~~^~~~~~~
/git/10.2/storage/connect/jsonudf.cpp:6010:7: error: variable 'fout' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
                if (!(fin = global_fopen(g, msgid, fn, "rt")))
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/git/10.2/storage/connect/jsonudf.cpp:6068:7: note: uninitialized use occurs here
                if (fout) fclose(fout);
                    ^~~~
/git/10.2/storage/connect/jsonudf.cpp:6010:3: note: remove the 'if' if its condition is always false
                if (!(fin = global_fopen(g, msgid, fn, "rt")))
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/git/10.2/storage/connect/jsonudf.cpp:6007:13: note: initialize the variable 'fout' to silence this warning
                FILE *fout;
                          ^
                           = NULL
3 errors generated.
make[2]: *** [storage/connect/CMakeFiles/connect.dir/jsonudf.cpp.o] Error 1
make[1]: *** [storage/connect/CMakeFiles/connect.dir/all] Error 2



 Comments   
Comment by Olivier Bertrand [ 2021-05-18 ]

diff storage/connect/bsonudf.cpp
+++ b/storage/connect/bsonudf.cpp
bsonudf.cpp:4685
-               PUSH_WARNING(g->Message ? g->Message : "Unexpected error");
+               PUSH_WARNING(*g->Message ? g->Message : "Unexpected error");
bsonudf.cpp:4745
-               FILE *fout;
+               FILE *fout = NULL;
bsonudf.cpp:4808
-               if (g->Message)
+               if (*g->Message)
 
diff storage/connect/jsonudf.cpp
jsonudf.cpp:5946
-               PUSH_WARNING(g->Message ? g->Message : "Unexpected error");
+               PUSH_WARNING(*g->Message ? g->Message : "Unexpected error");
jsonudf.cpp:6007
-               FILE *fout;
+               FILE *fout = NULL;
jsonudf.cpp:6074
-               if (g->Message)
+               if (*g->Message)

Generated at Thu Feb 08 09:39:48 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.