[MDEV-25602] MySQL bug# 20338 : get rid of __WIN__ in favor of standard _WIN32 Created: 2021-05-05  Updated: 2021-08-19  Resolved: 2021-08-19

Status: Closed
Project: MariaDB Server
Component/s: Compiling, Platform Windows
Affects Version/s: 10.1, 10.2, 10.3, 10.4, 10.5, 10.6
Fix Version/s: 10.6.5

Type: Bug Priority: Minor
Reporter: Vladislav Vaintroub Assignee: Vladislav Vaintroub
Resolution: Fixed Votes: 0
Labels: upstream-fixed

Issue Links:
PartOf
includes MDEV-25863 Connect : Replace __WIN__ by _WIN32 Closed
Relates
relates to MDEV-25861 POSIX Namespace reserves "_t" suffix;... Open

 Description   

This is the old MySQL bug https://bugs.mysql.com/bug.php?id=20338

Half of places are __WIN__, half of places are _WIN32. We could bring some order into the sources

__WIN__ is not really needed, all Windows compilers define WIN32 (yes, also the 64 ones), also ___WIN__ violates the standard, as noted in the MySQL bug :

It violates the rule of section 7.1.3 of ISO/IEC 9899:1999 (E):

All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use.
If the program declares or defines an identifier in a context in which it is reserved (other than as allowed by 7.1.4), or defines a reserved identifier as a macro name, the behavior is undefined.


Generated at Thu Feb 08 09:38:56 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.