[MDEV-25583] dh-systemd needs to be removed as a build dependency on Ubuntu/Debian Created: 2021-05-03  Updated: 2021-05-06  Resolved: 2021-05-04

Status: Closed
Project: MariaDB Server
Component/s: Compiling, Packaging
Fix Version/s: 10.5.10, 10.6.1

Type: Task Priority: Blocker
Reporter: Daniel Bartholomew Assignee: Vicențiu Ciorbaru
Resolution: Fixed Votes: 0
Labels: None


 Description   

On Ubuntu since 18.04 (Bionic) and Debian since at least 9 (Stretch), the dh-systemd package has been a dummy package without any actual purpose (the package only contains a copyright file and a changelog.gz file).

I believe the only distro we currently build for that has an actual dh-systemd package is Ubuntu 16.04 (Xenial), which is about to be deprecated after the upcoming 10.5.10 release.

More importantly, on Ubuntu 21.04 (Hirsute) the dh-systemd package has been completely removed, so MariaDB fails to compile there because of a missing dependency. Hirsute is only 10.5+, so the change only needs to go there.

So it is time to remove this package from our build dependencies. This could be done easily after the 10.5.10 release because after that we will be removing Xenial and we will then have no deb-based distro that actually has a real need for that package. If we need to provide Hirsute packages with the 10.5.10 release, we could still remove it, we would just need to have a workaround so that at least Xenial does still require it.



 Comments   
Comment by Vicențiu Ciorbaru [ 2021-05-04 ]

There was actually a patch already merged by danblack for this exact issue, authored by otto but it was never tested with Hirsute. The logic of the patch is to inject dh-systemd dependency when it is needed, but it failed to actually remove dh-systemd from debian/control.

Fixed fully with 1ff50a0edc42300bfbd45290ea64a5af33b46e22

Comment by Otto Kekäläinen [ 2021-05-06 ]

cvicentiu You are right, that one line must have dropped away during the rebase on 10.2.

I am happy to take ownership of things I did myself, and thus I've fixed this and other Sid/Hirsute build errors in PR https://github.com/MariaDB/server/pull/1826

https://github.com/MariaDB/server/commit/1ff50a0edc42300bfbd45290ea64a5af33b46e22 does not seem to be on any branch yet. You can discard it now as it in included in that PR.

See also related task https://jira.mariadb.org/browse/MDEV-25608 to get the builds for 10.2 fully working.

Generated at Thu Feb 08 09:38:47 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.