Trying bzr+ssh://bazaar.launchpad.net/~maria-captains/maria/10.0-mdev253 revno 3436.

Here is the simplest test case (more of a template for future test cases). It contains cnf and test files now, we'll record a result file later when we're satisfied with the way it works.

1. cat t/multisource1.cnf
   !include include/default_mysqld.cnf
   !include include/default_client.cnf

[mysqld.1]
server-id=1
log-bin=master-bin

[mysqld.2]
server-id=2
log-bin=master-bin

[mysqld.3]
server-id=3

[ENV]
SERVER_MYPORT_1= @mysqld.1.port
SERVER_MYSOCK_1= @mysqld.1.socket
SERVER_MYPORT_2= @mysqld.2.port
SERVER_MYSOCK_2= @mysqld.2.socket
SERVER_MYPORT_3= @mysqld.3.port
SERVER_MYSOCK_3= @mysqld.3.socket

1. cat t/multisource1.test
   --connect (slave,127.0.0.1,root,,,$SERVER_MYPORT_3)

eval change master 'slave1' to master_port=$SERVER_MYPORT_1, master_host='127.0.0.1', master_user='root';
eval change master 'slave2' to master_port=$SERVER_MYPORT_2, master_host='127.0.0.1', master_user='root';
start slave 'slave1';
start slave 'slave2';

query_vertical show full slave status;

stop slave 'slave1';

query_vertical show slave 'slave1' status;

I observe some problems with how server executes this test case.

1. stop slave 'slave1'; command throws a warning:

Warnings:
Note 1255 Slave already has been stopped

However, both before and after the command slave status shows that the slave is running.

Slave_IO_Running Yes
Slave_SQL_Running Yes

2. Slave produces memory-related errors:

Error: Safemalloc overrun buffer mysys/safemalloc.c:303, mysys/safemalloc.c:325, ??:0, ??:0, sql/mysqld.cc:1758, sql/mysqld.cc:5022, sql/main.cc:26, ??:0
Allocated at sql/rpl_mi.cc:48, sql/sql_parse.cc:2361, sql/sql_parse.cc:5813, sql/sql_parse.cc:1071, sql/sql_parse.cc:808, sql/sql_connect.cc:1253, sql/sql_connect.cc:1169, perfschema/pfs.cc:1017
Error: Safemalloc overrun buffer mysys/safemalloc.c:303, mysys/safemalloc.c:325, ??:0, ??:0, sql/mysqld.cc:1758, sql/mysqld.cc:5022, sql/main.cc:26, ??:0
Allocated at sql/rpl_mi.cc:48, sql/sql_parse.cc:2361, sql/sql_parse.cc:5813, sql/sql_parse.cc:1071, sql/sql_parse.cc:808, sql/sql_connect.cc:1253, sql/sql_connect.cc:1169, perfschema/pfs.cc:1017
Warning: 14 bytes lost, allocated at sql/rpl_mi.cc:48, sql/sql_parse.cc:2361, sql/sql_parse.cc:5813, sql/sql_parse.cc:1071, sql/sql_parse.cc:808, sql/sql_connect.cc:1253, sql/sql_connect.cc:1169, perfschema/pfs.cc:1017
Warning: 14 bytes lost, allocated at sql/rpl_mi.cc:48, sql/sql_parse.cc:2361, sql/sql_parse.cc:5813, sql/sql_parse.cc:1071, sql/sql_parse.cc:808, sql/sql_connect.cc:1253, sql/sql_connect.cc:1169, perfschema/pfs.cc:1017
Memory lost: 28 bytes in 2 chunks

3. In show full slave status, it looks like connection_name and slave_IO_state are switched:

Connection_name Checking master version
Slave_IO_State slave1

A couple times got the assertion failure:

mysqld: /home/elenst/10.0-mdev253/mysys/mf_iocache.c:1287: _my_b_seq_read: Assertion `pos_in_file == info->end_of_file' failed.
120925 5:11:52 [ERROR] mysqld got signal 6 ;

sporadic, no test case yet, will try to create it shortly.

Getting

Error: Freeing overrun buffer mysys/safemalloc.c:179, mysys/my_malloc.c:116, sql/rpl_mi.cc:76, sql/rpl_mi.cc:84, sql/rpl_mi.cc:596, mysys/hash.c:605, sql/rpl_mi.cc:984, sql/sql_reload.cc:338

while executing muti_source.simple
revno 3436
revision-id: monty@askmonty.org-20120925162756-ad39vfvitte0fulf
date: 2012-09-25 19:27:56 +0300

Server built as
cmake . -DCMAKE_BUILD_TYPE=Debug && make
on ubuntu 11.10 oneiric, x86_64

Error log excerpt:

120925 20:57:00 [Note] Master 'slave1': Slave I/O thread: connected to master 'root@127.0.0
.1:16000',replication started in log 'FIRST' at position 4
120925 20:57:00 [Note] Master 'slave2': Slave SQL thread initialized, starting replication
in log 'FIRST' at position 0, relay log './mysqld-relay-bin-slave2.000001' position: 4
120925 20:57:00 [Note] Master 'slave2': Slave I/O thread: connected to master 'root@127.0.0.1:16001',replication started in log 'FIRST' at position 4
120925 20:57:05 [Note] Master 'slave1': Error reading relay log event: slave SQL thread was killed
120925 20:57:05 [ERROR] Master 'slave1': Error reading packet from server: Lost connection to MySQL server during query ( server_errno=2013)
120925 20:57:05 [Note] Master 'slave1': Slave I/O thread killed while reading event
120925 20:57:05 [Note] Master 'slave1': Slave I/O thread exiting, read up to log 'master-bin.000001', position 286
120925 20:57:05 [Note] Deleted Master_info file '/home/elenst/10.0-mdev253/mysql-test/var/mysqld.3/data/master.info.slave1'.
120925 20:57:05 [Note] Deleted Master_info file '/home/elenst/10.0-mdev253/mysql-test/var/mysqld.3/data/relay-log.info.slave1'.
Error: Freeing overrun buffer mysys/safemalloc.c:179, mysys/my_malloc.c:116, sql/rpl_mi.cc:76, sql/rpl_mi.cc:84, sql/rpl_mi.cc:596, mysys/hash.c:605, sql/rpl_mi.cc:984, sql/sql_reload.cc:338
Allocated at sql/rpl_mi.cc:48, sql/sql_parse.cc:2361, sql/sql_parse.cc:5813, sql/sql_parse.cc:1071, sql/sql_parse.cc:808, sql/sql_connect.cc:1253, sql/sql_connect.cc:1169, perfschema/pfs.cc:1017
120925 20:57:05 [Note] Master 'slave2': Error reading relay log event: slave SQL thread was killed

Slave_IO_state and Connection_name still seem to be switched in SHOW FULL SLAVE STATUS:

show full slave status;
Connection_name Waiting for master to send event
Slave_IO_State master2
Master_Host 127.0.0.1

revno 3436
revision-id: monty@askmonty.org-20120925162756-ad39vfvitte0fulf
date: 2012-09-25 19:27:56 +0300

--sync_with_master 0, 'master1' doesn't work
(space AFTER the comma)

Upd: moved the description of the problem into MDEV-549

"RESET SLAVE 'masterX'" totally removes the masterX configuration.

Update: moved the description of the problem into subtask MDEV-548

Created a subtask https://mariadb.atlassian.net/browse/MDEV-547 for a problem with sql_slave_skip_counter (with a test file and result file).

Hopefully subtasks will be easier to track, a list of comments becomes messy.

Have not been able to repeat the problem with memory allocation until very late last night. Will fix tomorrow.
The problem with sql_slave_skip_counter was that this variable is not yet multi-source aware.

Have fixed the following issues:

• "Slave_IO_state and Connection_name still seem to be switched in SHOW FULL SLAVE STATUS"
• --sync_with_master 0, 'master1' doesn't work
• Made sql_slave_skip_counter

It's intentionally that RESET SLAVE removes the master configuration (this comes from the original patch).
The reason this method was used, is probably that there was no other logical way to remove a connection.
This does however create the problem of how to be able to remove the relay logs for a named connection.
The suggestions I have regarding this are:

• Let RESET SLAVE remove relay logs and the connection but FLUSH SLAVE would only remove relay logs.
• Add a DROP SLAVE 'connection_name' command.

Cannot we still use "RESET SLAVE 'name' ALL" to remove everything and "RESET SLAVE 'name'" to only remove the logs and position? It would be consistent with what we have for single-source: now 'RESET SLAVE ALL' removes the entire configuration, while 'RESET SLAVE' only removes logs and the position.

For the memory problem, I'll try to create a shorter test case, to reduce the amount of noise in the trace. The problem itself is reproducible on my machines and on perro, both with the plain cmake build and with BUILD/compile-pentium-debug-max. So if it doesn't happen on your boxes, maybe you could try there. I can set up the environment so you would only have to run the test.

With the new usage of max_relay_log_size we are getting extra warnings in the standard test suite (as below). Should we add the warnings to the result files, or are you planning to change the algorithm somehow?

CURRENT_TEST: rpl.rpl_deadlock_innodb
— mysql-test/suite/rpl/r/rpl_deadlock_innodb.result 2012-09-28 03:23:07.482695000 +0400
+++ mysql-test/suite/rpl/r/rpl_deadlock_innodb.reject 2012-10-01 22:52:05.107989763 +0400
@@ -76,6 +76,8 @@

• • • Test lock wait timeout and purged relay logs ***
      SET @my_max_relay_log_size= @@global.max_relay_log_size;
      SET global max_relay_log_size=0;
      +Warnings:
      +Warning 1292 Truncated incorrect max_relay_log_size value: '0'
      include/stop_slave.inc
      DELETE FROM t2;
      CHANGE MASTER TO MASTER_LOG_POS=<master_pos_begin>;

mysqltest: Result length mismatch

The warning for max_relay_log_size is ok in my opinion. Now it works like max_binlog_size and other variables.

Pushed into 10.0-base