[MDEV-24976] MYSQL_BIN_LOG::write_transaction_to_binlog - need_unlog detection loop is executed only once Created: 2021-02-25  Updated: 2023-05-17

Status: Open
Project: MariaDB Server
Component/s: None
Affects Version/s: None
Fix Version/s: 10.4, 10.5

Type: Bug Priority: Critical
Reporter: Yury Chaikou Assignee: Andrei Elkin
Resolution: Unresolved Votes: 0
Labels: None


 Description   

Looks like this break should be executed only when the condition is met, otherwise we will exit the loop after the first iteration.

/sql/log.cc - MYSQL_BIN_LOG::write_transaction_to_binlog

  for (; ha_info; ha_info= ha_info->next())
 
  {
 
    if (ha_info->is_started() && ha_info->ht() != binlog_hton &&
 
        !ha_info->ht()->commit_checkpoint_request)
 
      entry.need_unlog= true;
 
    break;           <------
 
  }


Generated at Thu Feb 08 09:34:09 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.