[MDEV-24798] libreadline-gplv2-dev removed from current Debian Sid, next Ubuntu and Debian Created: 2021-02-06  Updated: 2021-04-04  Resolved: 2021-04-04

Status: Closed
Project: MariaDB Server
Component/s: Packaging
Affects Version/s: 10.5
Fix Version/s: 10.5.9

Type: Bug Priority: Major
Reporter: Daniel Bartholomew Assignee: Otto Kekäläinen
Resolution: Fixed Votes: 0
Labels: None

Attachments: PNG File screencapture-jira-mariadb-org-browse-MCOL-4535-2021-03-13-18_38_27.png    

 Description   

The libreadline-gplv2-dev package has been removed from the current Debian Sid repositories because it was old and unmaintained.

Based on this: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980504 we should be able to switch over to using libeditreadline-dev, assuming a gplv2-compatible readline is still needed. That package is installed on the updated Sid builders on buildbot.askmonty.org.

In any case the current compile dependency in debian/control of libreadline-gplv2-dev means compiling on Sid is currently broken and will be broken in future releases of Debian and Ubuntu.

It's probably also worth noting that Sid now includes MariaDB 10.5, so any fix needs to go at least to there and higher.

 Comments   
Comment by Daniel Bartholomew [ 2021-02-06 ]

example compile failure:
https://buildbot.askmonty.org/buildbot/builders/kvm-deb-sid-amd64/builds/11703/steps/compile/logs/stdio

Comment by Daniel Bartholomew [ 2021-02-07 ]

Tried a build with the following adjustment to debian/control:

diff --git a/debian/control b/debian/control
 
index d6d097df24a..2f43b595f76 100644
 
--- a/debian/control
 
+++ b/debian/control
 
@@ -35,7 +35,7 @@ Build-Depends: bison,
 
                libnuma-dev [linux-any],
 
                libpam0g-dev,
 
                libpcre2-dev,
 
-               libreadline-gplv2-dev [amd64],
 
+               libreadline-gplv2-dev | libeditreadline-dev [amd64],
 
                libsnappy-dev,
 
                libssl-dev,
 
                libssl-dev:native,

It worked, the compile succeeded, but I don't fully understand the syntax of the control file, or if the change would mess up other builders (I don't think it would), so an actual dev should make the actual fix.

Comment by Otto Kekäläinen [ 2021-02-10 ]

That line is only for ColumnStore use. We don't ship in Debian.org ColumnStore at all, so the debian/control has been fixed there already ever since the server changed to libedit.

PR that closes this at https://github.com/MariaDB/server/pull/1754

Permanent fix comes when https://jira.mariadb.org/browse/MCOL-4535 is done in ColumnStore.

Comment by Otto Kekäläinen [ 2021-02-11 ]

Merged https://github.com/MariaDB/server/pull/1754 now. I'll continue with the final solution in this once https://github.com/mariadb-corporation/mariadb-columnstore-engine/commit/d9fa408ecee1e92b9724117aff65ffc2b00a0dee is in the mariadb/server/10.5 branch.

Comment by Otto Kekäläinen [ 2021-03-13 ]

Related issue MCOL-4535 ColumnStore should stop using the readline library was deleted today by toddstoffel, so storing a screenshot of it here for reference.

Comment by Otto Kekäläinen [ 2021-04-04 ]

The commit https://github.com/mariadb-corporation/mariadb-columnstore-engine/commit/d9fa408ecee1e92b9724117aff65ffc2b00a0dee for ColumnStore 5.5.1.2 is now on 10.5 and 10.6, so this issue is completely solved and can be closed.

Generated at Thu Feb 08 09:32:45 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.