[MDEV-24424] Unnecessary usage of to_float() for INSERT into the Spider table with float column Created: 2020-12-17 Updated: 2024-01-09 Resolved: 2021-08-13 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - Spider |
| Affects Version/s: | 10.4.7, 10.4.15, 10.4.18 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Major |
| Reporter: | Valerii Kravchuk | Assignee: | Nayuta Yanagisawa (Inactive) |
| Resolution: | Not a Bug | Votes: | 0 |
| Labels: | regression, regression-10.4 | ||
| Issue Links: |
|
||||||||
| Description |
|
Starting from 10.4.7+ (probably due to the fix for
Looks like function creation on the fly fails. In the general query log we see what happens:
INSERT works as expacted without FLOAT columns in the table. |
| Comments |
| Comment by Valerii Kravchuk [ 2020-12-17 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
It seems to help:
but I see no reason for this NOT to work that way by default:
I am also not sure why cast is needed above. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Kentoku Shiba (Inactive) [ 2020-12-21 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
> but I see no reason for this NOT to work that way by default: I just changed default wrapper from "mysql" to "mariadb" for 10.6. 2f6970e > I am also not sure why cast is needed above. Spider always cast it for float column for safety. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Sergei Golubchik [ 2020-12-23 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Kentoku, perhaps spider should be able to switch between "mysql" or "mariadb" wrapper depending on what server it connects to? | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Nayuta Yanagisawa (Inactive) [ 2021-08-13 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Always casting float columns seems to be rather a specification of the Spider, possibly for |