default value for sync_binlog should be the safer value 1 instead of 0
(MDEV-16589)
|
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Server |
| Affects Version/s: | None |
| Fix Version/s: | 10.6.0 |
| Type: | Technical task | Priority: | Critical |
| Reporter: | Sujatha Sivakumar (Inactive) | Assignee: | Axel Schwenke |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Comments |
| Comment by Julien Fritsch [ 2020-12-10 ] |
|
This sub-task has been created in order to allow the main issue to remain under Sujatha all the time. While it's blocking it, there will be a link between them to say so. axel I've added 3 days of estimation to avoid to have 0. But please update it with what you think. |
| Comment by Axel Schwenke [ 2021-01-25 ] |
|
I test a recent 10.6 build with loads with increasing write rate (90:10, read/write, write-only). Configurations are
In a first test run I have seen quite some impact from binlog_commit_wait_count = 8. I have however not seen any impact from binlog_commit_wait_usec. I see no point in testing with innodb_flush_log_at_trx_commit = 0. Or read-only workload. |
| Comment by Axel Schwenke [ 2021-01-25 ] |
|
Up to 64 threads (sysbench1.pdf For commit_wait_count=8 there is clearly a penalty for less then 8 benchmark threads and a performace benefit from 8 threads onward. This is expected. The commit_wait_count=1 line is identical to the one with only sync_binlog=1. Hence not shown in the diagrams. At 128 and 256 benchmark threads (sysbench2.pdf Conclusion: the effect of sync_binlog=1 on performance is about what would be expected. The extra disk write is visible by double the latency / half the throughput. Setting commit_wait_count to something higher than 1 helps a bit, but at the cost of througput at lower thread counts. |
| Comment by Axel Schwenke [ 2021-01-28 ] |
|
sujatha.sivakumar is that enough information for you? |
| Comment by Sujatha Sivakumar (Inactive) [ 2021-01-28 ] |
|
Hello Axel, Thank you for the benchmark results. My observations also seem to match with yours. This information sufficient for us as we could observe that, with sync_binlog=1, latency is doubled and throughput is half. Thank you. |
| Comment by Axel Schwenke [ 2021-02-16 ] |
|
Add a series with innodb_flush_log_at_trx_commit=0 to see what MDEV-18959 could do. |
| Comment by Axel Schwenke [ 2021-02-17 ] |
|
Uploaded a new result file: sysbench4.pdf
I left out the data points where it doesnt scale any more. |