[MDEV-24253] Refactor TABLE_SHARE::init_from_binary_frm_image Created: 2020-11-20 Updated: 2020-11-20 |
|
| Status: | Open |
| Project: | MariaDB Server |
| Component/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | Nikita Malyavin | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Description |
|
TABLE_SHARE::init_from_binary_frm_image is currently 1.5K lines long. This makes it impossible to navigate through. It is also inconvenient to debug error conditions because of long gotos. A stateful Share_frm_creator class could be introduced to work out the decomposition correctly, with respect to proper error handling. It will also ease the abstraction on the frm format. |