Apologies. Does changing "my_which" -> "which" work correctly?

Yes. I changed "my_which" to "which". Then mysqld_safe worked as expected.

Thanks.

danblack we can change my_which to which (solution 1)but there are other usecases in mysql_safe which are using my_which where additional check of IFS variable used and I'm planning to stick to this (so no solution 1).
The problem here is with PATH variable which cannot locate ldconfig.
So in addition we can export PATH=$PATH:/sbin after the first failure and again call my_which (solution 2)?
tomop which OS you are using and what will happen if you add /sbin to your PATH without changing my_which->which?

tomop which OS you are using and what will happen if you add /sbin to your PATH without changing my_which->which?

I'm using Vine Linux and MariaDB-10.5.7.

# env | grep PATH

PATH=/root/perl5/bin:/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin

# /etc/init.d/mysql start

Starting MariaDB.201105 23:08:41 mysqld_safe ldconfig command not found, required for ldconfig -p

"my_which" does not exist after 10.2. It shouldn't work.

So what is the output of which ldconfig ?

Oh I was looking into 10.2

So based on patch 355ee6877bec we should change it to command -v from 10.3+.

danblack please review patch

I applied the patch and mysqld_safe worked properly.

Thanks.

Looks good to me. I've pushed to a bb branch bb-10.3-anel-MDEV-24130 just to be sure it doesn't trip on anything.

$ scripts/mysqld_safe --malloc-lib=jemalloc

201106 15:36:13 mysqld_safe Adding '/lib64/libjemalloc.so.2' to LD_PRELOAD for mysqld

201106 15:36:13 mysqld_safe Logging to '/usr/local/mysql/data/linux.fritz.box.err'.

201106 15:36:13 mysqld_safe Starting mysqld daemon with databases from /usr/local/mysql/data

$ grep jemalloc /proc/186109/maps 

7fab34a13000-7fab34a19000 r--p 00000000 fd:01 1846215                    /usr/lib64/libjemalloc.so.2

7fab34a19000-7fab34a8d000 r-xp 00006000 fd:01 1846215                    /usr/lib64/libjemalloc.so.2

7fab34a8d000-7fab34a9b000 r--p 0007a000 fd:01 1846215                    /usr/lib64/libjemalloc.so.2

7fab34a9b000-7fab34aa1000 r--p 00087000 fd:01 1846215                    /usr/lib64/libjemalloc.so.2

7fab34aa1000-7fab34aa2000 rw-p 0008d000 fd:01 1846215                    /usr/lib64/libjemalloc.so.2

Merge after seeing bb passing with no failures attributable to this change.

Reviewed by danblack (missing information in commit message, sorry).
Closed with 3bf726f5ffc568b15e9788ed for 10.3
Thanks for the review Daniel.