screenshot-1.png
|
Blocks |
|||
| is blocked by |
|
Fix Jemalloc Dependency Issue | Closed |
[MDEV-24124] MariaDB Server sources contain binary blobs, source code missing Created: 2020-11-04 Updated: 2023-05-01 Resolved: 2023-05-01 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Packaging, Storage Engine - ColumnStore |
| Affects Version/s: | 10.5.7 |
| Fix Version/s: | 10.6.5 |
| Type: | Bug | Priority: | Major |
| Reporter: | Otto Kekäläinen | Assignee: | Gregory Dorman (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
screenshot-1.png
|
||||||||
| Issue Links: |
|
||||||||
| Description |
|
While importing MariaDB Server 10.5.7 into Debian I noticed in the sources the binary file:
This is a big no-no in an open source project for hopefully obvious reasons. Please remove it ASAP. |
| Comments |
| Comment by Otto Kekäläinen [ 2020-12-26 ] |
|
Any progress on this one? Which jemalloc.so is this exactly? What version, what arch? This should be pulled in at build-time as a dependency, not stored in git "sources". |
| Comment by Roman [ 2020-12-26 ] |
|
This jemalloc.so is taken from centos7 and used if the jemalloc package is |
| Comment by Roman [ 2020-12-26 ] |
|
There is no progress on this so far. We will begin with the replacement at |
| Comment by Roman [ 2020-12-26 ] |
|
IMHO this shouldn't be neither pulled nor stored but build from jemalloc |
| Comment by Otto Kekäläinen [ 2020-12-27 ] |
|
According to https://pkgs.org/search/?q=jemalloc libjemalloc-dev is available for Centos 7 and you could just use it as a build dependency like any other build dependency. |
| Comment by Roman [ 2020-12-27 ] |
|
It is in the external repo that is why there is a binary in the code. |
| Comment by Otto Kekäläinen [ 2023-03-12 ] |
|
This was fixed by in https://github.com/mariadb-corporation/mariadb-columnstore-engine/commit/c74beb617858bf4a8f9ae95ad25451cd99764c8a |
